From: Govind Singh <govinds@codeaurora.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Wei Yongjun <weiyongjun1@huawei.com>,
kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH net-next] ath10k: make some functions static
Date: Mon, 04 Jun 2018 19:11:54 +0530 [thread overview]
Message-ID: <c985c3eb7e845de729a34e094c1e3d35@codeaurora.org> (raw)
In-Reply-To: <20180604120400.GA6240@centauri.lan>
On 2018-06-04 17:34, Niklas Cassel wrote:
> On Mon, Jun 04, 2018 at 01:27:43PM +0300, Kalle Valo wrote:
>> Wei Yongjun <weiyongjun1@huawei.com> writes:
>>
>> > Fixes the following sparse warnings:
>> >
>> > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning:
>> > symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static?
>> > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning:
>> > symbol 'ath10k_snoc_init_napi' was not declared. Should it be static?
>> >
>> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> BTW this goes to my ath.git tree, not to net-next.
>>
>> I had missed these as I can't enable ATH10K_SNOC on x86 and hence I
>> don't test compile snoc.c at all. Bjorn&Govind, is there a way to
>> solve
>> that? IIRC we had a similar problem with wcn36xx but I don't remember
>> anymore how it was fixed.
>>
I tested compilation in x86 by removing ARCH_QCOM dependency last time.
>
> Perhaps something like:
>
> --- a/drivers/net/wireless/ath/ath10k/Kconfig
> +++ b/drivers/net/wireless/ath/ath10k/Kconfig
> @@ -42,7 +42,8 @@ config ATH10K_USB
>
> config ATH10K_SNOC
> tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)"
> - depends on ATH10K && ARCH_QCOM
> + depends on ATH10K
> + depends on ARCH_QCOM || COMPILE_TEST
> ---help---
> This module adds support for integrated WCN3990 chip
> connected
> to system NOC(SNOC). Currently work in progress and will not
>
>
> Regards,
> Niklas
>
Yes, This looks more appropriate and works well.
BR,
Govind
next prev parent reply other threads:[~2018-06-04 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 2:33 [PATCH net-next] ath10k: make some functions static Wei Yongjun
2018-06-04 10:27 ` Kalle Valo
2018-06-04 12:04 ` Niklas Cassel
2018-06-04 13:41 ` Govind Singh [this message]
2018-06-14 8:55 ` Kalle Valo
2018-06-14 13:55 ` Dan Carpenter
2018-06-14 14:18 ` Kalle Valo
2018-06-14 14:23 ` Dan Carpenter
2018-06-14 15:11 ` [net-next] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c985c3eb7e845de729a34e094c1e3d35@codeaurora.org \
--to=govinds@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).