From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5103CC433FE for ; Mon, 17 Oct 2022 08:02:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbiJQICu (ORCPT ); Mon, 17 Oct 2022 04:02:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbiJQICt (ORCPT ); Mon, 17 Oct 2022 04:02:49 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BBDB5B795 for ; Mon, 17 Oct 2022 01:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=4/93+lNqyYfJFAeyAUGmmcGLmRKHmLzUqwLyD1FbYAA=; t=1665993768; x=1667203368; b=nVs3GwICYSDaGPDcsC83DudsnTFTYcOiFmc4SP8G9jboLAN j8zOZifVqHJ3rqlagBDpx7+TTwMijQeiG+dE9kzYb4DOrhtnsNzzicfkPA0mV9u6+BqMOSz/Koumc Ap03cBaMdd5MC0leuVS4SCkMq/gGyn6cu+SV3eV6rmk+w7CN048MKLk5VoL9/gv7Ot//He74zrfMW P/jccHzV4O5VHG/3GNbGrcwaeEjIlkG6MfI22kQae3QLEhA2V3n68+YotO9RelZkAIiv7k+noncuA bwrgVLTG3lZ3RgIrS85IQS94Iw3kef9F/KDp0Olic0pgX7KiaodvveFq+36JJP6A==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1okL5C-009BmL-09; Mon, 17 Oct 2022 10:02:46 +0200 Message-ID: Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi From: Johannes Berg To: Wen Gong , linux-wireless Cc: ath11k@lists.infradead.org Date: Mon, 17 Oct 2022 10:02:45 +0200 In-Reply-To: References: <913ee04f-a16f-f765-96c2-0586282831b4@quicinc.com> <1a440c62-ffd0-9602-9454-f08765beadf0@quicinc.com> <91b975e2116521cfa9f9371a976039a53ed9a85c.camel@sipsolutions.net> <2a2c466fbdcc2c3cc7af81bcd4d370d0119ea865.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2022-10-17 at 16:00 +0800, Wen Gong wrote: > On 10/17/2022 3:49 PM, Johannes Berg wrote: > > On Mon, 2022-10-17 at 09:48 +0200, Johannes Berg wrote: > > > Hi, > > >=20 > > > > > Currently for MLO test, the others links's rx_nss of struct > > > > > ieee80211_link_sta is still value 0 in ieee80211_set_associated()= , > > > > > becaue they are not pass into ieee80211_sta_set_rx_nss() in > > > > > mac80211 except the deflink which means the primary link in > > > > > rate_control_rate_init(). This lead driver get nss =3D 0 for > > > > > other links. Will you fix it or is it design by default? > > > > >=20 > > > > > Only primary link has valid rx_nss value which is not 0 by below = call > > > > > stack. > > > > > ieee80211_assoc_success() > > > > > =C2=A0=C2=A0=C2=A0 ->rate_control_rate_init(sta); > > > > > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 ->ieee80211_sta_set_rx_nss= (&sta->deflink); > > > Right, none of the rate scaling related stuff was updated yet. > > >=20 > > Though for this case maybe we can just move ieee80211_sta_set_rx_nss() > > to some better place outside of rate_control_rate_init() and have it > > done with the right link, and also on changes? > >=20 > > johannes >=20 > I did below change in my internal test, and not found the NSS=3D0 issue= =20 > again for 2 link MLO. >=20 > wifi: mac80211: update all links rx nss by ieee80211_sta_set_rx_nss() in= =20 > ieee80211_assoc_success() >=20 I guess valid links wasn't set at that point yet? Anyway should also move out of rate_control_rate_init() and probably into something like ieee80211_assoc_config_link()? That already does some rx_nss calculations which is probably not great ... johannes