From: Ping-Ke Shih <pkshih@realtek.com>
To: "hanyu001@208suo.com" <hanyu001@208suo.com>,
"toke@toke.dk" <toke@toke.dk>,
"kvalo@kernel.org" <kvalo@kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] taging: fbtft: Add space around '='
Date: Tue, 18 Jul 2023 00:29:58 +0000 [thread overview]
Message-ID: <ca3fb1d8442c4de4949ecfd71c23b058@realtek.com> (raw)
In-Reply-To: <a8b204f8562cb5d4ad837f6df0c14b74@208suo.com>
> -----Original Message-----
> From: hanyu001@208suo.com <hanyu001@208suo.com>
> Sent: Monday, July 17, 2023 4:16 PM
> To: toke@toke.dk; kvalo@kernel.org
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] taging: fbtft: Add space around '='
>
> Fix checkpatch warnings:
>
> ./drivers/staging/media/av7110/dvb_filter.c:105: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:106: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:108: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:112: ERROR: spaces required
> around that '=' (ctx:VxV)
>
> Signed-off-by: maqimei <2433033762@qq.com>
> ---
> drivers/staging/media/av7110/dvb_filter.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/av7110/dvb_filter.c
> b/drivers/staging/media/av7110/dvb_filter.c
> index 8c2eca5..014fa1f 100644
> --- a/drivers/staging/media/av7110/dvb_filter.c
> +++ b/drivers/staging/media/av7110/dvb_filter.c
> @@ -102,14 +102,14 @@ int dvb_filter_pes2ts(struct dvb_filter_pes2ts
> *p2ts, unsigned char *pes,
> }
> if (!len)
> return 0;
> - buf[3]=0x30|((p2ts->cc++)&0x0f);
> - rest=183-len;
> + buf[3] = 0x30|((p2ts->cc++)&0x0f);
> + rest = 183-len;
Adding spaces around operators | and & would look better:
buf[3] = 0x30 | ((p2ts->cc++) & 0x0f);
rest = 183 - len;
prev parent reply other threads:[~2023-07-18 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_1D773A0CE6639082173515B942C9821A6D09@qq.com>
2023-07-17 8:15 ` [PATCH] taging: fbtft: Add space around '=' hanyu001
2023-07-18 0:29 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca3fb1d8442c4de4949ecfd71c23b058@realtek.com \
--to=pkshih@realtek.com \
--cc=hanyu001@208suo.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).