* [PATCH] taging: fbtft: Add space around '='
[not found] <tencent_1D773A0CE6639082173515B942C9821A6D09@qq.com>
@ 2023-07-17 8:15 ` hanyu001
2023-07-18 0:29 ` Ping-Ke Shih
0 siblings, 1 reply; 2+ messages in thread
From: hanyu001 @ 2023-07-17 8:15 UTC (permalink / raw)
To: toke, kvalo; +Cc: linux-wireless, linux-kernel
Fix checkpatch warnings:
./drivers/staging/media/av7110/dvb_filter.c:105: ERROR: spaces required
around that '=' (ctx:VxV)
./drivers/staging/media/av7110/dvb_filter.c:106: ERROR: spaces required
around that '=' (ctx:VxV)
./drivers/staging/media/av7110/dvb_filter.c:108: ERROR: spaces required
around that '=' (ctx:VxV)
./drivers/staging/media/av7110/dvb_filter.c:112: ERROR: spaces required
around that '=' (ctx:VxV)
Signed-off-by: maqimei <2433033762@qq.com>
---
drivers/staging/media/av7110/dvb_filter.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/av7110/dvb_filter.c
b/drivers/staging/media/av7110/dvb_filter.c
index 8c2eca5..014fa1f 100644
--- a/drivers/staging/media/av7110/dvb_filter.c
+++ b/drivers/staging/media/av7110/dvb_filter.c
@@ -102,14 +102,14 @@ int dvb_filter_pes2ts(struct dvb_filter_pes2ts
*p2ts, unsigned char *pes,
}
if (!len)
return 0;
- buf[3]=0x30|((p2ts->cc++)&0x0f);
- rest=183-len;
+ buf[3] = 0x30|((p2ts->cc++)&0x0f);
+ rest = 183-len;
if (rest) {
- buf[5]=0x00;
+ buf[5] = 0x00;
if (rest-1)
memset(buf+6, 0xff, rest-1);
}
- buf[4]=rest;
+ buf[4] = rest;
memcpy(buf+5+rest, pes, len);
return p2ts->cb(p2ts->priv, buf);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] taging: fbtft: Add space around '='
2023-07-17 8:15 ` [PATCH] taging: fbtft: Add space around '=' hanyu001
@ 2023-07-18 0:29 ` Ping-Ke Shih
0 siblings, 0 replies; 2+ messages in thread
From: Ping-Ke Shih @ 2023-07-18 0:29 UTC (permalink / raw)
To: hanyu001@208suo.com, toke@toke.dk, kvalo@kernel.org
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: hanyu001@208suo.com <hanyu001@208suo.com>
> Sent: Monday, July 17, 2023 4:16 PM
> To: toke@toke.dk; kvalo@kernel.org
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] taging: fbtft: Add space around '='
>
> Fix checkpatch warnings:
>
> ./drivers/staging/media/av7110/dvb_filter.c:105: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:106: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:108: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:112: ERROR: spaces required
> around that '=' (ctx:VxV)
>
> Signed-off-by: maqimei <2433033762@qq.com>
> ---
> drivers/staging/media/av7110/dvb_filter.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/av7110/dvb_filter.c
> b/drivers/staging/media/av7110/dvb_filter.c
> index 8c2eca5..014fa1f 100644
> --- a/drivers/staging/media/av7110/dvb_filter.c
> +++ b/drivers/staging/media/av7110/dvb_filter.c
> @@ -102,14 +102,14 @@ int dvb_filter_pes2ts(struct dvb_filter_pes2ts
> *p2ts, unsigned char *pes,
> }
> if (!len)
> return 0;
> - buf[3]=0x30|((p2ts->cc++)&0x0f);
> - rest=183-len;
> + buf[3] = 0x30|((p2ts->cc++)&0x0f);
> + rest = 183-len;
Adding spaces around operators | and & would look better:
buf[3] = 0x30 | ((p2ts->cc++) & 0x0f);
rest = 183 - len;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-18 0:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_1D773A0CE6639082173515B942C9821A6D09@qq.com>
2023-07-17 8:15 ` [PATCH] taging: fbtft: Add space around '=' hanyu001
2023-07-18 0:29 ` Ping-Ke Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).