Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Ho Jie Feng <hjf3108@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v2 4/5] wifi: rtlwifi: usb: move the radiotap headroom size to usb.h
Date: Tue, 17 Nov 2026 01:51:21 +0000	[thread overview]
Message-ID: <ca7a2c3c220c4d2eb1e4f57fe66450ba@realtek.com> (raw)
In-Reply-To: <20261110080143.1362021-5-hjf3108@gmail.com>

Ho Jie Feng <hjf3108@gmail.com> wrote:
> Let drivers use the same define to add headroom for the frames
> split out of aggregated transfers.
> 
> Move __RADIO_TAP_SIZE_RSV to usb.h as RTL_RADIO_TAP_SIZE_RSV
> so chip specific code can use it.
> 
> Signed-off-by: Ho Jie Feng <hjf3108@gmail.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Carry my Acked-by to v3 with a nit below.

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.h
> b/drivers/net/wireless/realtek/rtlwifi/usb.h
> index b873bbc9c4..329b734ca1 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/usb.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/usb.h
> @@ -7,6 +7,7 @@
>  #include <linux/skbuff.h>
> 
>  #define RTL_RX_DESC_SIZE               24
> +#define RTL_RADIO_TAP_SIZE_RSV 32

nit: prefer to align the column of number. 
Though I'm not fan of <tabs + space> alignment, it is there already.
Just let it look comfortable. 

> 
>  #define RTL_USB_DEVICE(vend, prod, cfg) \
>         .match_flags = USB_DEVICE_ID_MATCH_DEVICE, \
> --
> 2.53.0


  reply	other threads:[~2026-11-17  1:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  8:01 [PATCH rtw-next v2 0/5] wifi: rtlwifi: rtl8192du fixes and additional support Ho Jie Feng
2026-11-10  8:01 ` [PATCH rtw-next v2 1/5] wifi: rtlwifi: rc: start no BA session for QoS null frames Ho Jie Feng
2026-11-17  1:43   ` Ping-Ke Shih
2026-11-10  8:01 ` [PATCH rtw-next v2 2/5] wifi: rtlwifi: rtl8192d: report no signal for frames without PHY status Ho Jie Feng
2026-11-17  1:45   ` Ping-Ke Shih
2026-11-10  8:01 ` [PATCH rtw-next v2 3/5] wifi: rtlwifi: usb: unify the RX code path Ho Jie Feng
2026-11-10  8:01 ` [PATCH rtw-next v2 4/5] wifi: rtlwifi: usb: move the radiotap headroom size to usb.h Ho Jie Feng
2026-11-17  1:51   ` Ping-Ke Shih [this message]
2026-11-10  8:01 ` [PATCH rtw-next v2 5/5] wifi: rtlwifi: rtl8192du: enable USB RX aggregation Ho Jie Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca7a2c3c220c4d2eb1e4f57fe66450ba@realtek.com \
    --to=pkshih@realtek.com \
    --cc=hjf3108@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox