Re: [PATCH] iwlcore: Allow runtime configuration of no_sleep_autoadjust

reinette chatre
2009-11-09T23:01:46Z

Hi Andrew,

On Mon, 2009-11-09 at 14:47 -0800, Andrew Lutomirski wrote:
> On Mon, Nov 9, 2009 at 5:21 PM, reinette chatre
> <reinette.chatre@intel.com> wrote:
> > Hi Andrew,
> >
> > On Mon, 2009-11-09 at 10:07 -0800, Andrew Lutomirski wrote:
> >> Hmm. It looks like sleep_level_override in debugfs can do exactly what I want.
> >
> > You have not really stated what you are trying to do here so it is hard
> > to tell. sleep_level_override lets you hardcode the power saving index.
> >
> >>
> >> Is there any reason that no_sleep_autoadjust doesn't just make
> >> sleep_level_override default to 1?
> >
> > That does seem what it is doing in iwl_power_update_mode().
>
> I want to save power. no_sleep_autoadjust=N and iwconfig wlan0 power
> on does a good job of that. I assume that no_sleep_autoadjust
> defaults to Y because it's still not reliable (and I seem to have seen
> a few networks where it causes occasional problems). So I'd like to
> be able to toggle it at runtime, file bug reports when it fails, but
> still be able to use the networks it fails on :)

Perhaps you could add a new debugfs file to modify no_sleep_autoadjust.
This will enable you to write the new power command to the device after
the setting has changed, similar to what is done in
iwl_dbgfs_sleep_level_override_write. This will ensure that your setting
takes effect at the time you make the change.

Reinette