From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 182DCC433B4 for ; Thu, 8 Apr 2021 11:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8DEE6113D for ; Thu, 8 Apr 2021 11:11:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbhDHLLu (ORCPT ); Thu, 8 Apr 2021 07:11:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbhDHLLu (ORCPT ); Thu, 8 Apr 2021 07:11:50 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 664F4C061760 for ; Thu, 8 Apr 2021 04:11:39 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lUSZU-008yRl-3z; Thu, 08 Apr 2021 13:11:36 +0200 Message-ID: Subject: Re: [PATCH 1/3] nl80211: Add support for beacon tx mode From: Johannes Berg To: Sven Eckelmann , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Maharaja Kennadyrajan Date: Thu, 08 Apr 2021 13:11:34 +0200 In-Reply-To: <2718995.X0rUDs3ZmB@ripper> (sfid-20210222_113458_463202_DAC50CAC) References: <1613988573-10839-1-git-send-email-mkenna@codeaurora.org> <1613988573-10839-2-git-send-email-mkenna@codeaurora.org> <2718995.X0rUDs3ZmB@ripper> (sfid-20210222_113458_463202_DAC50CAC) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2021-02-22 at 11:32 +0100, Sven Eckelmann wrote: > On Monday, 22 February 2021 11:09:31 CET Maharaja Kennadyrajan wrote: > > User can configure the beacon tx mode while bring-up the AP > > or MESH. Hence, added the support in the nl80211/cfg80211 > > layer to honour the beacon tx mode configuration and pass > > this value to the driver. > > There is not a definition what this actually means. But I am guessing that you > are mean the way the HW sends our the beacons for a multivif (beaconing) > setup. And in this case, it is a per "phy" setting and not a per AP/meshpoint > setting, right? In addition, the commit logs are not explaining anything, why you'd use it, why it's necessary, etc. I'll say it again: @codeaurora folks, consider the community, not just your own driver. I'm really getting tired of having to extract information from you. johannes