From: Felix Fietkau <nbd@nbd.name>
To: Anthony Liu <anthony.liu@mediatek.com>, lorenzo@kernel.org
Cc: Sean.Wang@mediatek.com, Leon.Yen@mediatek.com,
Quan.Zhou@mediatek.com, Ryder.lee@mediatek.com,
litien.chang@mediatek.com, kun.wu@mediatek.com,
jb.tsai@mediatek.com, emery.hsin@mediatek.com,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 5/5] [PATCH v4] [PATCH 05/05] wifi: mt76: mt7922/mt7928: send Tx/Rx statistics to FW for link tuning
Date: Tue, 6 Oct 2026 16:48:31 +0200 [thread overview]
Message-ID: <cb2f423f-b3eb-4d19-9fe1-ccc19c9690b2@nbd.name> (raw)
In-Reply-To: <20261005083155.104718-1-anthony.liu@mediatek.com>
Hi,
On 05.10.26 10:31, Anthony Liu wrote:
> Update Tx/Rx statistics to FW for link speed tuning in FW.
>
> Signed-off-by: Anthony Liu <anthony.liu@mediatek.com>
A few issues in this series:
1. Please fix the email subject
2. It seems that some places may need checks to exclude mt7921.
3. Some duplication in debugfs.c
4. mt792x_mcu_set_perf_ind could be static
5. Check if the pointer derefs in mt792x_perf_account_rx are safe.
Aside from this, I also have some questions:
- is this on by default or can it only be enabled via debugfs?
- why does the host have to keep statistics on tx/rx, when the firmware
could do that and handle it internally?
Thanks,
- Felix
prev parent reply other threads:[~2026-10-06 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 8:31 [PATCH v4 5/5] [PATCH v4] [PATCH 05/05] wifi: mt76: mt7922/mt7928: send Tx/Rx statistics to FW for link tuning Anthony Liu
2026-10-06 14:48 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb2f423f-b3eb-4d19-9fe1-ccc19c9690b2@nbd.name \
--to=nbd@nbd.name \
--cc=Leon.Yen@mediatek.com \
--cc=Quan.Zhou@mediatek.com \
--cc=Ryder.lee@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=anthony.liu@mediatek.com \
--cc=emery.hsin@mediatek.com \
--cc=jb.tsai@mediatek.com \
--cc=kun.wu@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=litien.chang@mediatek.com \
--cc=lorenzo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).