From: Luciano Coelho <luciano.coelho@intel.com>
To: Yue Haibing <yuehaibing@huawei.com>,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
linuxwifi@intel.com, kvalo@codeaurora.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] iwlwifi: Use correct channel_profile iniwl_get_nvm
Date: Wed, 17 Apr 2019 10:14:06 +0300 [thread overview]
Message-ID: <cb50133154f8b8913dfe00231eeef77b3f650955.camel@intel.com> (raw)
In-Reply-To: <20190417032409.23924-1-yuehaibing@huawei.com>
On Wed, 2019-04-17 at 11:24 +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> commit 2785ce008e3b ("iwlwifi: support new NVM response API")
> seems forgot use correct channel_profile in iwl_get_nvm when call
> iwl_init_sbands().
>
> Fixes: 2785ce008e3b ("iwlwifi: support new NVM response API")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
> b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
> index 40985dc..d87a6bb 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
> @@ -1496,7 +1496,7 @@ struct iwl_nvm_data *iwl_get_nvm(struct
> iwl_trans *trans,
> (void *)rsp_v3->regulatory.channel_profile;
>
> iwl_init_sbands(trans->dev, trans->cfg, nvm,
> - rsp->regulatory.channel_profile,
> + channel_profile,
> nvm->valid_tx_ant & fw->valid_tx_ant,
> nvm->valid_rx_ant & fw->valid_rx_ant,
> sbands_flags, v4);
Thanks!
This was a rebase damage I made when sending this upstream. I've
applied this directly to our upstream feeding tree because it's not
wrong in our internal tree.
--
Cheers,
Luca.
prev parent reply other threads:[~2019-04-17 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 3:24 [PATCH] iwlwifi: Use correct channel_profile iniwl_get_nvm Yue Haibing
2019-04-17 7:14 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb50133154f8b8913dfe00231eeef77b3f650955.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox