RE: [RFC PATCH v1 0/9] wifi: rtw88: add RTL8723B/RTL8723BS support

[Ping-Ke Shih <pkshih@realtek.com>]

Hi Luka,

Luka Gejak <luka.gejak@linux.dev> wrote:
> Hi Ping-Ke,
> 
> Thanks for the review, and for taking the time on a series this size.
> 
> Before I send v2 I want to report what changed, because the result of
> your comments is that the series gets noticeably smaller. I would
> rather tell you now than have you spend review time on patches I am
> about to delete.

I think you can send v2 as smaller patchset now if you have done it.

In short, I prefer first patchset is to add RTL8723BS with fewer special
cases as possible, and patches looks like
 - add hard required handling for RTL8723BS
 - add RTL8923B main body
 - add Kconfig & Makefile
 - add MAINTAINERS

If special cases are still needed, you can submit them after first
version gets merged. 

> 
> Answers to your questions from the cover letter first.
> 
> 1. The link. Michael Straube's original work is now referenced in the
>    chip patch:
> 
>      https://github.com/mistraube/rtw88/tree/rtl8723bs

Adding this to cover letter for reference will be good for reviewers. 

> 
>    The current state of my series is here, if it is easier to read than
>    mail:
> 
>      https://github.com/MocLG/rtw/tree/8723bs-upstream

I have not seen the detail, but good to have it.

> 
> 2. sparse and smatch. Both re-run on the new series, clean, no findings
>    in the 8723b/8723bs files.

Please keep running the checks afterward. As well as checkpatch.pl I forgot
to mention. 

> 
> 3. Bluetooth coexistence. Tested as you asked: WiFi download while an
>    A2DP sink plays music, shared antenna, 2.4 GHz HT40.
> 

[...]

> 
>    The reported BT coex version is 0x69, below the 0x6d the 1ant
>    parameters expect. Is the rtl8723bs BT firmware currently shipped in
>    linux-firmware older than the coex protocol these parameters were
>    written for, and should I be using a different blob? 

Sorry. I'm not sure. Perhaps, you can try rtlwifi/rtl8723befw.bin or
rtlwifi/rtl8723befw_36.bin (WiFi firmware) to see if it is better. 

(To prevent linux-firmware maintainer merge your submission right now, 
 you might need to drop your submission of rtw88/rtw8723b_fw.bin temporarily?)

> 
> Now the larger change.

Thanks for your follows.
 
> Two caveats I want to state plainly rather than have you find them.

As I mentioned at beginning, we can add special cases after first version
get merged. At that time, we can discuss each problem in detail by patch.

> I will hold v2 until you have had a chance to react to the removals, in
> case any of them should stay, and to pick up whatever else you find in
> the patches that remain.

I will stop reviewing v1 to avoid redundant works. You can send v2 now, but
please give me some time. 

Ping-Ke