RE: [PATCH rtw-next v2] wifi: rtw88: TX QOS Null data the same way as Null data

[Ping-Ke Shih <pkshih@realtek.com>]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> When filling out the TX descriptor, Null data frames are treated like
> management frames, but QOS Null data frames are treated like normal
> data frames. Somehow this causes a problem for the firmware.
> 
> When connected to a network in the 2.4 GHz band, wpa_supplicant (or
> NetworkManager?) triggers a scan every five minutes. During these scans
> mac80211 transmits many QOS Null frames in quick succession. Because
> these frames are marked with IEEE80211_TX_CTL_REQ_TX_STATUS, rtw88
> asks the firmware to report the TX ACK status for each of these frames.
> Sometimes the firmware can't process the TX status requests quickly
> enough, they add up, it only processes some of them, and then marks
> every subsequent TX status report with the wrong number.
> 
> The symptom is that after a while the warning "failed to get tx report
> from firmware" appears every five minutes.
> 
> This problem apparently happens only with the older RTL8723D, RTL8821A,
> RTL8812A, and probably RTL8703B chips.
> 
> Treat QOS Null data frames the same way as Null data frames. This seems
> to avoid the problem.
> 
> Tested with RTL8821AU, RTL8723DU, RTL8811CU, and RTL8812BU.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>