From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>,
ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, jjohnson@kernel.org,
vasanthakumar.thiagarajan@oss.qualcomm.com
Subject: Re: [PATCH ath-next v2] wifi: ath12k: Fix NAPI resource leaks in AHB external IRQ paths
Date: Mon, 12 Oct 2026 14:35:50 +0800 [thread overview]
Message-ID: <cc107d66-df4b-4a77-b0d2-2106a02620ca@oss.qualcomm.com> (raw)
In-Reply-To: <20261001045423.493121-1-aaradhana.sahu@oss.qualcomm.com>
On 10/1/2026 12:54 PM, Aaradhana Sahu wrote:
> Currently, NAPI instances and their associated netdevs allocated for AHB
> external IRQ groups are not released when external IRQ configuration
> fails. They are also not freed when arch_init() fails after
> ath12k_ahb_config_irq() succeeds during probe, or when the driver is
> unloaded.
>
> Fix this by adding a common cleanup helper to release the NAPI instances
> and associated netdevs. Call it from the external IRQ configuration error
> path, probe error path, and driver cleanup path.
>
> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01275-QCAHKSWPL_SILICONZ-1
>
> Fixes: 6cee30f0da75 ("wifi: ath12k: add AHB driver support for IPQ5332")
> Fixes: 614c23e24ee8 ("wifi: ath12k: Support arch-specific DP device allocation")
> Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
next prev parent reply other threads:[~2026-10-12 6:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 4:54 [PATCH ath-next v2] wifi: ath12k: Fix NAPI resource leaks in AHB external IRQ paths Aaradhana Sahu
2026-10-08 17:16 ` Rameshkumar Sundaram
2026-10-09 3:38 ` Aaradhana Sahu
2026-10-09 20:41 ` Jeff Johnson
2026-10-12 9:19 ` Aaradhana Sahu
2026-10-09 20:17 ` Jeff Johnson
2026-10-12 15:00 ` Jeff Johnson
2026-10-12 6:35 ` Baochen Qiang [this message]
2026-10-12 8:59 ` Rameshkumar Sundaram
2026-10-13 1:05 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc107d66-df4b-4a77-b0d2-2106a02620ca@oss.qualcomm.com \
--to=baochen.qiang@oss.qualcomm.com \
--cc=aaradhana.sahu@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vasanthakumar.thiagarajan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox