linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Greenman, Gregory" <gregory.greenman@intel.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"aiden.leong@aibsd.com" <aiden.leong@aibsd.com>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH v2] wifi: iwlwifi: pcie: add support for AX101NGW
Date: Thu, 19 Jan 2023 15:24:40 +0000	[thread overview]
Message-ID: <cd1eaa92ba4e5cc8da9715368fbcd1249335977e.camel@intel.com> (raw)
In-Reply-To: <20230106050548.9112-1-aiden.leong@aibsd.com>

On Fri, 2023-01-06 at 13:05 +0800, Aiden Leong wrote:
> Fix a bug introduced by: 
> commit 32ed101aa140 ("iwlwifi: convert all Qu with Jf devices to the new
>  config table"), so now we pick the FIRST matching config.
> 
> Signed-off-by: Aiden Leong <aiden.leong@aibsd.com>
> ---
> 
> I split patchset v1 to two standalone patches, since there are not that
> strongly related to each other.
> 
> ---
>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> index a46df1320372..5d74adbd49cf 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> @@ -1461,7 +1461,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
>         if (!num_devices)
>                 return NULL;
>  
> -       for (i = num_devices - 1; i >= 0; i--) {
> +       for (i = 0; i < num_devices; i++) {
>                 const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i];
>  
>                 if (dev_info->device != (u16)IWL_CFG_ANY &&

The fix is ok, but please update the subject... It's not only for this specific
device, but just fixing the order of scanning iwl_dev_info_table.


      reply	other threads:[~2023-01-19 15:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06  5:05 [PATCH v2] wifi: iwlwifi: pcie: add support for AX101NGW Aiden Leong
2023-01-19 15:24 ` Greenman, Gregory [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd1eaa92ba4e5cc8da9715368fbcd1249335977e.camel@intel.com \
    --to=gregory.greenman@intel.com \
    --cc=aiden.leong@aibsd.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).