From: Balaji Pothunoori <bpothuno@codeaurora.org>
To: Bob Copeland <me@bobcopeland.com>
Cc: johannes@sipsolutions.net, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org,
Ashok Raj Nagarajan <arnagara@codeaurora.org>
Subject: Re: [PATCH v4 1/3] cfg80211: Add support to set tx power for a station associated
Date: Tue, 02 Apr 2019 12:00:29 +0530 [thread overview]
Message-ID: <cd497042d164c322bc06c4cfbf26435a@codeaurora.org> (raw)
In-Reply-To: <20190401204611.GA8910@localhost>
On 2019-04-02 02:16, Bob Copeland wrote:
> Hi Balaji,
>
> I started playing with these patches a bit -- they could be useful for
> my use case, but I had a question:
>
>> + * @power: tx power (in dBm) to be used for sending data traffic. If
>> tx power
>> + * is not provided, the default per-interface tx power setting will
>> be
>> + * overriding. Driver should be picking up the lowest tx power,
>> either tx
>> + * power per-interface or per-station.
>
> Should this really dBm? It's a bit asymmetric for WIPHY_TX_POWER_LEVEL
> to
> use mBm and this to use dBm, and I might want to adjust in half-dB
> steps if
> supported by hardware. Also allocating an s16 is a bit much for dBm.
if user will send mBm value then driver has to convert to dBm because
firmware will expect the value in dBm.
Please refer johannes comments on following patch " [EXT] Re: [PATCH]
iw: Add support for controlling tx power for per station"
for the reason why we opted dBm.
Yeah, s16 is required if units in mBm. i will modify to s8 in next
version patch.
Regards,
Balaji.
next prev parent reply other threads:[~2019-04-02 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 10:48 [PATCH v4 1/3] cfg80211: Add support to set tx power for a station associated Balaji Pothunoori
2019-03-31 6:00 ` kbuild test robot
2019-04-01 20:46 ` Bob Copeland
2019-04-02 6:30 ` Balaji Pothunoori [this message]
2019-04-02 12:59 ` Bob Copeland
2019-04-02 13:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd497042d164c322bc06c4cfbf26435a@codeaurora.org \
--to=bpothuno@codeaurora.org \
--cc=arnagara@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).