From: Johannes Berg <johannes@sipsolutions.net>
To: Amith A <amith.a@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH wireless-next v2] wifi: mac80211: use wiphy_hrtimer_work for CAC timeout
Date: Mon, 02 Feb 2026 10:07:50 +0100 [thread overview]
Message-ID: <ce0fc7ade5da7639aa6fe6e7d6bd4bcb0629bf3c.camel@sipsolutions.net> (raw)
In-Reply-To: <20260130035511.2328713-1-amith.a@oss.qualcomm.com> (sfid-20260130_045519_750372_09502D8D)
On Fri, 2026-01-30 at 09:25 +0530, Amith A wrote:
>
> struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
> + ktime_t ktime = ktime_set(0, ms_to_ktime(cac_time_ms));
> struct ieee80211_chan_req chanreq = { .oper = *chandef };
> struct ieee80211_local *local = sdata->local;
> struct ieee80211_link_data *link_data;
> @@ -3874,8 +3875,7 @@ static int ieee80211_start_radar_detection(struct wiphy *wiphy,
> if (err)
> return err;
>
> - wiphy_delayed_work_queue(wiphy, &link_data->dfs_cac_timer_work,
> - msecs_to_jiffies(cac_time_ms));
> + wiphy_hrtimer_work_queue(wiphy, &link_data->dfs_cac_timer_work, ktime);
This is really questionable on multiple counts (at least the variable
name, the ktime_set call arguments), I've fixed it to just do
ms_to_ktime(cac_time_ms) in the argument ...
johannes
prev parent reply other threads:[~2026-02-02 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 3:55 [PATCH wireless-next v2] wifi: mac80211: use wiphy_hrtimer_work for CAC timeout Amith A
2026-02-02 9:07 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce0fc7ade5da7639aa6fe6e7d6bd4bcb0629bf3c.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amith.a@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox