From: Johannes Berg <johannes@sipsolutions.net>
To: Sarika Sharma <quic_sarishar@quicinc.com>
Cc: linux-wireless@vger.kernel.org,
Hari Chandrakanthan <quic_haric@quicinc.com>
Subject: Re: [PATCH wireless-next] wifi: mac80211: add tx_handlers_drop statistics to ethtool
Date: Thu, 04 Sep 2025 11:26:58 +0200 [thread overview]
Message-ID: <ce5f2bd899caa2de32f36ce554d9cada073979c0.camel@sipsolutions.net> (raw)
In-Reply-To: <20250822052110.513804-1-quic_sarishar@quicinc.com>
On Fri, 2025-08-22 at 10:51 +0530, Sarika Sharma wrote:
> Currently tx_handlers_drop statistics are handled only for slow TX
> path and only at radio level. This also requires
> CONFIG_MAC80211_DEBUG_COUNTERS to be enabled to account the dropped
> packets. There is no way to check these stats for fast TX,
> at interface level and monitor without enabling the debug configuration.
>
> Hence, add a new counter at the sdata level to track packets dropped
> with reason as TX_DROP during transmission for fast path, slow path
> and other tx management packets. Expose this via ethtool statistics,
> to improve visibility into transmission failures at interface level
> and aid debugging and performance monitoring.
>
> Place the counter in ethtool with other available tx_* stats for
> better readability and accurate tracking.
As much as I don't like ethtool for wifi, I guess you found a use where
it's actually the right thing to use even in wifi ;-)
But why not remove the old debug statistic, you have a superset now?
johannes
next prev parent reply other threads:[~2025-09-04 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 5:21 [PATCH wireless-next] wifi: mac80211: add tx_handlers_drop statistics to ethtool Sarika Sharma
2025-09-04 9:26 ` Johannes Berg [this message]
2025-09-08 15:55 ` Sarika Sharma
2025-09-09 12:07 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce5f2bd899caa2de32f36ce554d9cada073979c0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_haric@quicinc.com \
--cc=quic_sarishar@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).