From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Ho Jie Feng" <hjf3108@gmail.com>, "Ping-Ke Shih" <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, "Ho Jie Feng" <hjf3108@gmail.com>
Subject: Re: [PATCH rtw-next v2 0/7] wifi: rtw88: extend 88xxA support
Date: Fri, 06 Nov 2026 17:44:16 +0000 [thread overview]
Message-ID: <cf3ac5de969de93866dc9221521443608bae307d@linux.dev> (raw)
In-Reply-To: <20261031070950.425176-1-hjf3108@gmail.com>
Hi Jie Feng,
Thanks for the v2. I have a couple of comments for cover letter.
October 31, 2026 at 8:09 AM, "Ho Jie Feng" <hjf3108@gmail.com> wrote:
> This series enables HT STBC transmission, VHT SU beamformed reception,
> carrier-frequency-offset correction and adaptivity on supported
> 88xxA devices.
There is no changelog since v1. Could you add one to the cover letter
in v3, with what changed in new version and a link to the previous
one? It makes it easier for reviewers to quickly regain context and
makes it easier to track changes across versions.
> Tested on RTL8812AU together with the driver-frame series.
> TX went from 136.0 to 144.2.
> RX went from 215.5 to 249.2.
If the series you tested with is the one that became 62e69ef45567
("wifi: rtw88: usb: don't report the aggregation buffer as a frame"),
it is in rtw-next now, so for v3 testing on plain rtw-next should be
enough.
[ ... ]
> base-commit: 9b0be45d4d52fd223994e151f169743a97abd290
v2 no longer applies to rtw-next. ec2baa4c9317 ("wifi: rtw88: Pass the
physical map to the read_efuse chip op") went in after you posted it and
changed the rtw88xxa_read_efuse() line next to the new code in patch 2,
so v3 needs a rebase. After fixing that one conflict the rest applied
for me.
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-11-06 17:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 7:09 [PATCH rtw-next v2 0/7] wifi: rtw88: extend 88xxA support Ho Jie Feng
2026-10-31 7:09 ` [PATCH rtw-next v2 1/7] wifi: rtw88: 8812a, 8814a: enable STBC for HT transmissions Ho Jie Feng
2026-11-06 17:21 ` Luka Gejak
2026-10-31 7:09 ` [PATCH rtw-next v2 2/7] wifi: rtw88: 88xxa: receive VHT SU beamformed transmissions Ho Jie Feng
2026-11-03 16:36 ` Bitterblue Smith
2026-11-06 17:23 ` Luka Gejak
2026-10-31 7:09 ` [PATCH rtw-next v2 3/7] wifi: rtw88: correctly expose beamformee capabilities Ho Jie Feng
2026-11-06 17:25 ` Luka Gejak
2026-10-31 7:09 ` [PATCH rtw-next v2 4/7] wifi: rtw88: prepare frequency-offset correction for more chips Ho Jie Feng
2026-10-31 7:09 ` [PATCH rtw-next v2 5/7] wifi: rtw88: 88xxa: correct carrier-frequency offset Ho Jie Feng
2026-11-06 17:27 ` Luka Gejak
2026-11-06 20:03 ` Bitterblue Smith
2026-11-09 13:39 ` Ho Jie Feng
2026-11-10 8:03 ` Luka Gejak
2026-10-31 7:09 ` [PATCH rtw-next v2 6/7] wifi: rtw88: 88xxa: adapt channel sensing to receiver gain Ho Jie Feng
2026-11-03 17:41 ` Bitterblue Smith
2026-11-04 12:47 ` Ho Jie Feng
2026-11-06 17:34 ` Luka Gejak
2026-11-06 19:46 ` Bitterblue Smith
2026-11-06 20:27 ` Luka Gejak
2026-11-10 14:36 ` Bitterblue Smith
2026-11-10 19:57 ` Luka Gejak
2026-10-31 7:09 ` [PATCH rtw-next v2 7/7] wifi: rtw88: 8812a, 8821a: respect peer A-MPDU size limits Ho Jie Feng
2026-11-06 17:35 ` Luka Gejak
2026-11-08 18:09 ` Jie Feng
2026-11-09 7:25 ` Luka Gejak
2026-11-06 17:44 ` Luka Gejak [this message]
2026-11-08 18:10 ` [PATCH rtw-next v2 0/7] wifi: rtw88: extend 88xxA support Jie Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3ac5de969de93866dc9221521443608bae307d@linux.dev \
--to=luka.gejak@linux.dev \
--cc=hjf3108@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox