From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] wifi: mac80211: add ieee80211_txq_aql_pending()
Date: Mon, 23 Mar 2026 11:55:09 +0100 [thread overview]
Message-ID: <cfbedb0dded5917d35e62936013a387285520645.camel@sipsolutions.net> (raw)
In-Reply-To: <20260323101954.874299-4-nbd@nbd.name>
On Mon, 2026-03-23 at 10:19 +0000, Felix Fietkau wrote:
>
> +u32 ieee80211_txq_aql_pending(struct ieee80211_hw *hw,
> + struct ieee80211_txq *txq)
> +{
> + struct ieee80211_local *local = hw_to_local(hw);
> + struct sta_info *sta;
> +
> + if (!txq->sta)
> + return atomic_read(&local->aql_bc_pending_airtime);
> +
> + sta = container_of(txq->sta, struct sta_info, sta);
> +
> + if (unlikely(txq->tid == IEEE80211_NUM_TIDS))
> + return 0;
I think better to put that check before the !txq->sta check. I don't
think it's there yet, but I think NAN is adding a per-interface mgmt
queue or so. Better to just cover all the cases here now.
johannes
next prev parent reply other threads:[~2026-03-23 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 10:19 [PATCH 1/4] wifi: mac80211: factor out part of ieee80211_calc_expected_tx_airtime Felix Fietkau
2026-03-23 10:19 ` [PATCH 2/4] wifi: mac80211: estimate expected throughput if not provided by driver/rc Felix Fietkau
2026-03-23 10:35 ` Johannes Berg
2026-03-23 10:19 ` [PATCH 3/4] wifi: mac80211: add AQL support for broadcast packets Felix Fietkau
2026-03-23 10:38 ` Johannes Berg
2026-03-23 10:19 ` [PATCH 4/4] wifi: mac80211: add ieee80211_txq_aql_pending() Felix Fietkau
2026-03-23 10:39 ` Johannes Berg
2026-03-23 10:43 ` Felix Fietkau
2026-03-23 10:55 ` Johannes Berg [this message]
2026-03-23 16:00 ` [PATCH 1/4] wifi: mac80211: factor out part of ieee80211_calc_expected_tx_airtime Pablo MARTIN-GOMEZ
2026-03-25 3:58 ` Felix Fietkau
2026-03-25 11:21 ` Pablo MARTIN-GOMEZ
2026-03-25 11:41 ` Felix Fietkau
2026-03-25 13:05 ` Pablo MARTIN-GOMEZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfbedb0dded5917d35e62936013a387285520645.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox