From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7226932D7C7 for ; Mon, 23 Mar 2026 10:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774263313; cv=none; b=Q2UktsxndIhkSYOmxlDwViMkuQXy4f87kJu3+PTXFKGgLHQWGXFq2JV7YlXfzkB3L7DBcizXDDy6DFmBJ7oinWcMIpOxIzrH2X/tJWSORkjvPr+5mGgJ85Xh6JIXrOWY5i3adxj8FaYu1voLeflo1Yt2A1vIbD0kKhJTpdOHU80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774263313; c=relaxed/simple; bh=GnYxp243Yqqae4eYxesQG0t32Ur10J7RnTwruI0EB+o=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=mcOXGlMhXmV0z4cOOxwwoyRPFYZN6wxylIdi14S0amwBtdG+cV8gk1bnbpMHfCOwE17My/FdNE0VlUO9Ffd8e52zhFbpK1GSXGlZeW2maQpwDQJKGXvYDQ9f9cg3Kb8JCcEOrK7sL9mlkU9V9uc23ZYtppdrEL+1mGtd8vqWnoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=G6kWTQ8q; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="G6kWTQ8q" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=+rtJEMZzW+gcodCKGrHHsBvjctr2FqosgqoQqchbBjQ=; t=1774263312; x=1775472912; b=G6kWTQ8q78p/xwX7pLZ808C2bhQR8acQRnOYl9FfIC9i96p l+KPgqLqCffaZc61muB92nd0VHVsG8mLjX+0UuY9AO/LQhCzaGzWaBu6Cmc/okR1NrI0RRV2q0Q1F 9iMJ8I4zBfPJlsA5kuu7W00Rvw7PEra3WJog9r6tNBBRLgEI+pTF4Y8V1WuDHB/7FgDBtBbTnbUnh w0uwtC8eQU9SsB6CFbI9c5QCJg7bhbvs2CHNwT+g4HSPsB/v/AjVkMrDFXSci/bV+vkg0lPoHm2TP y5FkD3LpG9aHaGRNggt40NW2xOs8nEVHqaH9EDsOjAjwKudHDpjVjv4NwiBhAloQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1w4cwA-00000009igj-1EfH; Mon, 23 Mar 2026 11:55:10 +0100 Message-ID: Subject: Re: [PATCH 4/4] wifi: mac80211: add ieee80211_txq_aql_pending() From: Johannes Berg To: Felix Fietkau , linux-wireless@vger.kernel.org Date: Mon, 23 Mar 2026 11:55:09 +0100 In-Reply-To: <20260323101954.874299-4-nbd@nbd.name> References: <20260323101954.874299-1-nbd@nbd.name> <20260323101954.874299-4-nbd@nbd.name> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Mon, 2026-03-23 at 10:19 +0000, Felix Fietkau wrote: >=20 > +u32 ieee80211_txq_aql_pending(struct ieee80211_hw *hw, > + struct ieee80211_txq *txq) > +{ > + struct ieee80211_local *local =3D hw_to_local(hw); > + struct sta_info *sta; > + > + if (!txq->sta) > + return atomic_read(&local->aql_bc_pending_airtime); > + > + sta =3D container_of(txq->sta, struct sta_info, sta); > + > + if (unlikely(txq->tid =3D=3D IEEE80211_NUM_TIDS)) > + return 0; I think better to put that check before the !txq->sta check. I don't think it's there yet, but I think NAN is adding a per-interface mgmt queue or so. Better to just cover all the cases here now. johannes