linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] mwl8k: Fixing sparse warnings
@ 2014-03-06 15:12 Yogesh Ashok Powar
  2014-03-06 15:12 ` [PATCH 1/2] mwl8k: le32_to_cpu cast to restricted Yogesh Ashok Powar
  2014-03-06 15:12 ` [PATCH 2/2] mwl8k: mwl8k_update_survey can be static Yogesh Ashok Powar
  0 siblings, 2 replies; 3+ messages in thread
From: Yogesh Ashok Powar @ 2014-03-06 15:12 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-wireless, Lennert Buytenhek, Nishant Sarmukadam

Fixing Sparse warnings.

Yogesh Ashok Powar (2):
  mwl8k: le32_to_cpu is redandant on ioread32
  mwl8k: mwl8k_update_survey can be static

 drivers/net/wireless/mwl8k.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
1.8.3.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] mwl8k: le32_to_cpu cast to restricted
  2014-03-06 15:12 [PATCH 0/2] mwl8k: Fixing sparse warnings Yogesh Ashok Powar
@ 2014-03-06 15:12 ` Yogesh Ashok Powar
  2014-03-06 15:12 ` [PATCH 2/2] mwl8k: mwl8k_update_survey can be static Yogesh Ashok Powar
  1 sibling, 0 replies; 3+ messages in thread
From: Yogesh Ashok Powar @ 2014-03-06 15:12 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-wireless, Lennert Buytenhek, Nishant Sarmukadam

It fixes couple of sparse check
>#make C=1 CF=-D__CHECK_ENDIAN__ drivers/net/wireless/mwl8k.o
>drivers/net/wireless/mwl8k.c:3104:19: warning: cast to restricted __le32
>drivers/net/wireless/mwl8k.c:3108:18: warning: cast to restricted __le32

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Nishant Sarmukadam <nishants@marvell.com>
Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
---
 drivers/net/wireless/mwl8k.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index b6d83f6..706a445 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -3103,11 +3103,11 @@ void mwl8k_update_survey(struct mwl8k_priv *priv,
 
 	survey = &priv->survey[idx];
 
-	cca_cnt = le32_to_cpu(ioread32(priv->regs + NOK_CCA_CNT_REG));
+	cca_cnt = ioread32(priv->regs + NOK_CCA_CNT_REG);
 	cca_cnt /= 1000; /* uSecs to mSecs */
 	survey->channel_time_busy = (u64) cca_cnt;
 
-	rx_rdy = le32_to_cpu(ioread32(priv->regs + BBU_RXRDY_CNT_REG));
+	rx_rdy = ioread32(priv->regs + BBU_RXRDY_CNT_REG);
 	rx_rdy /= 1000; /* uSecs to mSecs */
 	survey->channel_time_rx = (u64) rx_rdy;
 
-- 
1.8.3.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] mwl8k: mwl8k_update_survey can be static
  2014-03-06 15:12 [PATCH 0/2] mwl8k: Fixing sparse warnings Yogesh Ashok Powar
  2014-03-06 15:12 ` [PATCH 1/2] mwl8k: le32_to_cpu cast to restricted Yogesh Ashok Powar
@ 2014-03-06 15:12 ` Yogesh Ashok Powar
  1 sibling, 0 replies; 3+ messages in thread
From: Yogesh Ashok Powar @ 2014-03-06 15:12 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-wireless, Lennert Buytenhek, Nishant Sarmukadam

It fixes following sparse check warning
>#make C=1 CF=-D__CHECK_ENDIAN__ drivers/net/wireless/mwl8k.o
>drivers/net/wireless/mwl8k.c:3089:6: warning: symbol 'mwl8k_update_survey' was not declared. Should it be static?

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Nishant Sarmukadam <nishants@marvell.com>
Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
---
 drivers/net/wireless/mwl8k.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index 706a445..3c0a0a8 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -3088,8 +3088,8 @@ exit:
 	return idx;
 }
 
-void mwl8k_update_survey(struct mwl8k_priv *priv,
-			 struct ieee80211_channel *channel)
+static void mwl8k_update_survey(struct mwl8k_priv *priv,
+				struct ieee80211_channel *channel)
 {
 	u32 cca_cnt, rx_rdy;
 	s8 nf = 0, idx;
-- 
1.8.3.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-03-06 15:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-06 15:12 [PATCH 0/2] mwl8k: Fixing sparse warnings Yogesh Ashok Powar
2014-03-06 15:12 ` [PATCH 1/2] mwl8k: le32_to_cpu cast to restricted Yogesh Ashok Powar
2014-03-06 15:12 ` [PATCH 2/2] mwl8k: mwl8k_update_survey can be static Yogesh Ashok Powar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).