* [PATCH 00/19] staging: Remove unnecessary externs
@ 2015-08-10 21:51 Joe Perches
2015-08-10 21:51 ` [PATCH 18/19] staging: wilc1000: " Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2015-08-10 21:51 UTC (permalink / raw)
To: devel, driverdev-devel, ac100, linux-tegra, speakup,
linux-wireless
Cc: linux-kernel, linux-iio, HPDD-discuss
trivial neatening of prototypes
Joe Perches (19):
staging: android: Remove unnecessary externs
staging: dgnc: Remove unnecessary externs
staging: fbtft: Remove unnecessary externs
staging: ft1000: Remove unnecessary externs
staging: iio: Remove unnecessary externs
staging: lustre: Remove unnecessary externs
staging: most: Remove unnecessary externs
staging: mt29f_spinand: Remove unnecessary externs
staging: netlogic: Remove unnecessary externs
staging: nvec: Remove unnecessary externs
staging: octeon: Remove unnecessary externs
staging: olpc_dcon: Remove unnecessary externs
staging: rtl8188eu: Remove unnecessary externs
staging: rtl8192e: Remove unnecessary externs
staging: rtl8192u: Remove unnecessary externs
staging: rtl8712: Remove unnecessary externs
staging: speakup: Remove unnecessary externs
staging: wilc1000: Remove unnecessary externs
staging: xgifb: Remove unnecessary externs
drivers/staging/android/sync.h | 10 +-
drivers/staging/dgnc/dgnc_sysfs.h | 16 +-
drivers/staging/fbtft/fbtft.h | 52 ++-
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h | 19 +-
drivers/staging/ft1000/ft1000-usb/ft1000_usb.h | 4 +-
drivers/staging/iio/meter/ade7854.h | 4 +-
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 2 +-
.../staging/lustre/lnet/klnds/socklnd/socklnd.h | 141 +++++----
drivers/staging/lustre/lnet/selftest/console.h | 90 +++---
.../staging/lustre/lustre/include/lprocfs_status.h | 313 +++++++++----------
.../lustre/lustre/include/lustre/lustre_idl.h | 133 ++++----
.../lustre/lustre/include/lustre/lustre_user.h | 2 +-
drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 +-
.../staging/lustre/lustre/include/lustre_export.h | 4 +-
.../staging/lustre/lustre/include/lustre_import.h | 4 +-
drivers/staging/lustre/lustre/include/lustre_net.h | 16 +-
drivers/staging/lustre/lustre/include/obd_class.h | 16 +-
.../staging/lustre/lustre/include/obd_support.h | 6 +-
drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 2 +-
drivers/staging/lustre/lustre/libcfs/tracefile.h | 32 +-
.../staging/lustre/lustre/llite/llite_internal.h | 16 +-
drivers/staging/most/hdm-dim2/dim2_hal.h | 8 +-
drivers/staging/mt29f_spinand/mt29f_spinand.h | 4 +-
drivers/staging/netlogic/xlr_net.h | 2 +-
drivers/staging/nvec/nvec.h | 19 +-
drivers/staging/octeon/ethernet-mdio.h | 2 +-
drivers/staging/octeon/octeon-ethernet.h | 22 +-
drivers/staging/olpc_dcon/olpc_dcon.h | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 2 +-
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 8 +-
drivers/staging/rtl8188eu/include/sta_info.h | 18 +-
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.h | 10 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 4 +-
.../staging/rtl8192e/rtl8192e/r8192E_firmware.h | 2 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h | 52 ++-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 22 +-
drivers/staging/rtl8192e/rtllib.h | 347 ++++++++++-----------
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 345 ++++++++++----------
drivers/staging/rtl8192u/r8190_rtl8256.h | 11 +-
drivers/staging/rtl8192u/r8192U.h | 2 +-
drivers/staging/rtl8192u/r8192U_dm.h | 36 +--
drivers/staging/rtl8192u/r8192U_wx.h | 2 +-
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 8 +-
drivers/staging/rtl8192u/r819xU_phy.h | 55 ++--
drivers/staging/rtl8712/rtl871x_ioctl.h | 28 +-
drivers/staging/speakup/i18n.h | 12 +-
drivers/staging/speakup/speakup.h | 68 ++--
drivers/staging/wilc1000/coreconfigurator.h | 30 +-
drivers/staging/wilc1000/linux_wlan_common.h | 4 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 2 +-
drivers/staging/xgifb/vb_init.h | 4 +-
drivers/staging/xgifb/vb_setmode.h | 34 +-
52 files changed, 1007 insertions(+), 1042 deletions(-)
--
2.1.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 18/19] staging: wilc1000: Remove unnecessary externs
2015-08-10 21:51 [PATCH 00/19] staging: Remove unnecessary externs Joe Perches
@ 2015-08-10 21:51 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2015-08-10 21:51 UTC (permalink / raw)
To: devel, Johnny Kim, Rachel Kim, Dean Lee, Chris Park
Cc: Greg Kroah-Hartman, linux-wireless, linux-kernel
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 30 +++++++++++------------
drivers/staging/wilc1000/linux_wlan_common.h | 4 +--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 2 +-
3 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index 56ff2ba..3af1935 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -163,27 +163,27 @@ typedef struct wid_site_survey_reslts {
} wid_site_survey_reslts_s;
#endif
-extern s32 CoreConfiguratorInit(void);
-extern s32 CoreConfiguratorDeInit(void);
+s32 CoreConfiguratorInit(void);
+s32 CoreConfiguratorDeInit(void);
-extern s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
- u32 u32WIDsCount, bool bRespRequired, u32 drvHandler);
-extern s32 ParseNetworkInfo(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo);
-extern s32 DeallocateNetworkInfo(tstrNetworkInfo *pstrNetworkInfo);
+s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
+ u32 u32WIDsCount, bool bRespRequired, u32 drvHandler);
+s32 ParseNetworkInfo(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo);
+s32 DeallocateNetworkInfo(tstrNetworkInfo *pstrNetworkInfo);
-extern s32 ParseAssocRespInfo(u8 *pu8Buffer, u32 u32BufferLen,
- tstrConnectRespInfo **ppstrConnectRespInfo);
-extern s32 DeallocateAssocRespInfo(tstrConnectRespInfo *pstrConnectRespInfo);
+s32 ParseAssocRespInfo(u8 *pu8Buffer, u32 u32BufferLen,
+ tstrConnectRespInfo **ppstrConnectRespInfo);
+s32 DeallocateAssocRespInfo(tstrConnectRespInfo *pstrConnectRespInfo);
#ifndef CONNECT_DIRECT
-extern s32 ParseSurveyResults(u8 ppu8RcvdSiteSurveyResults[][MAX_SURVEY_RESULT_FRAG_SIZE],
- wid_site_survey_reslts_s **ppstrSurveyResults,
- u32 *pu32SurveyResultsCount);
-extern s32 DeallocateSurveyResults(wid_site_survey_reslts_s *pstrSurveyResults);
+s32 ParseSurveyResults(u8 ppu8RcvdSiteSurveyResults[][MAX_SURVEY_RESULT_FRAG_SIZE],
+ wid_site_survey_reslts_s **ppstrSurveyResults,
+ u32 *pu32SurveyResultsCount);
+s32 DeallocateSurveyResults(wid_site_survey_reslts_s *pstrSurveyResults);
#endif
-extern s32 SendRawPacket(s8 *pspacket, s32 s32PacketLen);
-extern void NetworkInfoReceived(u8 *pu8Buffer, u32 u32Length);
+s32 SendRawPacket(s8 *pspacket, s32 s32PacketLen);
+void NetworkInfoReceived(u8 *pu8Buffer, u32 u32Length);
void GnrlAsyncInfoReceived(u8 *pu8Buffer, u32 u32Length);
void host_int_ScanCompleteReceived(u8 *pu8Buffer, u32 u32Length);
diff --git a/drivers/staging/wilc1000/linux_wlan_common.h b/drivers/staging/wilc1000/linux_wlan_common.h
index 2476bfd..e6ebf3e 100644
--- a/drivers/staging/wilc1000/linux_wlan_common.h
+++ b/drivers/staging/wilc1000/linux_wlan_common.h
@@ -39,8 +39,8 @@ enum debug_region {
#define FIRM_DBG (1 << Firmware_debug)
#if defined (WILC_DEBUGFS)
-extern int wilc_debugfs_init(void);
-extern void wilc_debugfs_remove(void);
+int wilc_debugfs_init(void);
+void wilc_debugfs_remove(void);
extern atomic_t REGION;
extern atomic_t DEBUG_LEVEL;
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h
index c25350c..97b663b 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h
@@ -123,7 +123,7 @@ struct net_device *WILC_WFI_init_mon_interface(const char *name, struct net_devi
#ifdef TCP_ENHANCEMENTS
#define TCP_ACK_FILTER_LINK_SPEED_THRESH 54
#define DEFAULT_LINK_SPEED 72
-extern void Enable_TCP_ACK_Filter(bool value);
+void Enable_TCP_ACK_Filter(bool value);
#endif
#endif
--
2.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-10 21:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-10 21:51 [PATCH 00/19] staging: Remove unnecessary externs Joe Perches
2015-08-10 21:51 ` [PATCH 18/19] staging: wilc1000: " Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).