public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Baochen Qiang <quic_bqiang@quicinc.com>, <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] wifi: ath12k: change MAC buffer ring size to 2048
Date: Wed, 29 Nov 2023 07:35:44 -0800	[thread overview]
Message-ID: <d012ddc8-3578-43da-9787-e44dcc4e7206@quicinc.com> (raw)
In-Reply-To: <20231129020414.56425-4-quic_bqiang@quicinc.com>

On 11/28/2023 6:04 PM, Baochen Qiang wrote:
> For WCN7850, there is a SRNG named MAC buffer ring, i.e.,
> dp->rx_mac_buf_ring. During initialization, it is setup
> by host and then under control of firmware. During RX
> process, firmware fetches buffers from
> dp->rx_refill_buf_ring to fill that MAC buffer ring,
> and those buffers are taken by RXDMA to carry real WLAN
> frames received from air.
> 
> Currently a low RX throughput is observed. Checking
> firmware log, lots of errors are reported by MAC buffer
> ring, complaining that it is running out of buffers,
> which further indicates that RXDMA is suffering from
> starvation. Currently the size of dp->rx_mac_buf_ring
> is configured as 1024. After changing it to 2048, those
> error messages are reduced, and a 6.4% increase is seen
> in peak throughput. Note that 2048 is an empirical
> value. It is chosen here because the RX throughput
> meets our expectation after the change.
> 
> This change only applies to WCN7850 since other
> chips don't have a MAC buffer ring.
> 
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
> 
> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>


  reply	other threads:[~2023-11-29 15:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29  2:04 [PATCH v2 0/3] wifi: ath12k: some improvement to RX throughput Baochen Qiang
2023-11-29  2:04 ` [PATCH v2 1/3] wifi: ath12k: fix wrong definitions of hal_reo_update_rx_queue Baochen Qiang
2023-11-29 15:35   ` Jeff Johnson
2024-01-18  5:52   ` Kalle Valo
2023-11-29  2:04 ` [PATCH v2 2/3] wifi: ath12k: add support for BA1024 Baochen Qiang
2023-11-29 15:35   ` Jeff Johnson
2023-11-29  2:04 ` [PATCH v2 3/3] wifi: ath12k: change MAC buffer ring size to 2048 Baochen Qiang
2023-11-29 15:35   ` Jeff Johnson [this message]
2024-01-17 13:46 ` [PATCH v2 0/3] wifi: ath12k: some improvement to RX throughput Kalle Valo
2024-01-17 15:32   ` Jeff Johnson
2024-01-18  2:21     ` Baochen Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d012ddc8-3578-43da-9787-e44dcc4e7206@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_bqiang@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox