From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Michael Buesch" <mb@bu3sch.de>
Cc: "John Linville" <linville@tuxdriver.com>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: Use input-polldev for the rfkill switch
Date: Wed, 10 Oct 2007 10:30:35 -0400 [thread overview]
Message-ID: <d120d5000710100730j243247e1te570ff57522693eb@mail.gmail.com> (raw)
In-Reply-To: <200709281422.34434.mb@bu3sch.de>
Hi Michael,
On 9/28/07, Michael Buesch <mb@bu3sch.de> wrote:
> This removes the direct call to rfkill on an rfkill event
> and replaces it with an input device. This way userspace is also
> notified about the event.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> Index: wireless-2.6/drivers/net/wireless/b43/Kconfig
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/b43/Kconfig 2007-09-27 21:31:15.000000000 +0200
> +++ wireless-2.6/drivers/net/wireless/b43/Kconfig 2007-09-28 12:34:23.000000000 +0200
> @@ -70,7 +70,7 @@ config B43_LEDS
> # RFKILL support
> config B43_RFKILL
> bool
> - depends on B43 && RFKILL
> + depends on B43 && RFKILL && RFKILL_INPUT && INPUT_POLLDEV
> default y
I don't think that broadcom driver should depend on RFKILL_INPUT...
RFKILL_INPUT is a default link between input and rfkill layers but it
is by no means a mandatory component.
I think proper dependency should be:
depends on B43 && RFKILL && INPUT
select INPUT_POLLDEV
--
Dmitry
next prev parent reply other threads:[~2007-10-10 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 12:22 [PATCH] b43: Use input-polldev for the rfkill switch Michael Buesch
2007-09-29 16:52 ` David Woodhouse
2007-09-29 17:08 ` Michael Buesch
2007-09-29 17:14 ` David Woodhouse
2007-09-29 17:32 ` Michael Buesch
2007-09-29 18:09 ` David Woodhouse
2007-10-10 14:30 ` Dmitry Torokhov [this message]
2007-10-10 14:36 ` Michael Buesch
2007-10-10 14:51 ` Dmitry Torokhov
2007-10-10 15:00 ` Michael Buesch
2007-10-10 15:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000710100730j243247e1te570ff57522693eb@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).