From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH rtw-next] wifi: rtlwifi: rtl8821ae: Fix C2H bit location in RX descriptor
Date: Mon, 27 Apr 2026 02:16:19 +0000 [thread overview]
Message-ID: <d1c3fad594524619b661bb793792026b@realtek.com> (raw)
In-Reply-To: <04da7398-cedb-425a-a810-5772ab10139d@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> Bit 28 of double word 2 in the RX descriptor indicates if the packet is
> a normal 802.11 frame, or a message from the wifi firmware to the
> driver (Card 2 Host).
>
> Commit f5678bfe1cdc ("rtlwifi: rtl8821ae: Replace local bit manipulation
> macros") mistakenly made the driver look for this bit in double word 1,
> causing packet loss and Bluetooth coexistence problems.
The mistake in the commit is
#define GET_RX_STATUS_DESC_RPT_SEL(__pdesc) \
- LE_BITS_TO_4BYTE(__pdesc+8, 28, 1)
+ le32_get_bits(*((__le32 *)(__pdesc + 4)), BIT(28))
>
> Fixes: f5678bfe1cdc ("rtlwifi: rtl8821ae: Replace local bit manipulation macros")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2026-04-27 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 19:32 [PATCH rtw-next] wifi: rtlwifi: rtl8821ae: Fix C2H bit location in RX descriptor Bitterblue Smith
2026-04-27 2:16 ` Ping-Ke Shih [this message]
2026-04-29 5:55 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1c3fad594524619b661bb793792026b@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox