From: Ping-Ke Shih <pkshih@realtek.com>
To: Nicolas Escande <nico.escande@gmail.com>,
P Praneesh <quic_ppranees@quicinc.com>,
"ath12k@lists.infradead.org" <ath12k@lists.infradead.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 3/3] wifi: ath12k: fix firmware crash during reo reinject
Date: Wed, 22 May 2024 06:59:17 +0000 [thread overview]
Message-ID: <d276dbb98e1d4b82ada054e1e54f48e8@realtek.com> (raw)
In-Reply-To: <D1F6ZU89YWPF.X1SZ9JNQNPFC@gmail.com>
Nicolas Escande <nico.escande@gmail.com> wrote:
[...]
> > - reo_ent_ring->queue_addr_lo = reo_dest_ring->rx_mpdu_info.peer_meta_data;
> > - reo_ent_ring->info0 = le32_encode_bits(dst_ind,
> > + reo_ent_ring->queue_addr_lo = cpu_to_le32(lower_32_bits(rx_tid->paddr));
> > + queue_addr_hi = upper_32_bits(rx_tid->paddr);
> Shouldn't there be a cpu_to_le32 somewhere here ? It just seems asymetrical
> between the two values extracted from rx_tid->paddr
> > + reo_ent_ring->info0 = le32_encode_bits(queue_addr_hi,
le32_encode_bits() will convert queue_addr_hi from cpu-order to le-order.
> > + HAL_REO_ENTR_RING_INFO0_QUEUE_ADDR_HI) |
> > + le32_encode_bits(dst_ind,
> > HAL_REO_ENTR_RING_INFO0_DEST_IND);
> >
> > reo_ent_ring->info1 = le32_encode_bits(rx_tid->cur_sn,
>
next prev parent reply other threads:[~2024-05-22 6:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 7:00 [PATCH 0/3] wifi: ath12k: fix issues in rx fragmentation path P Praneesh
2024-05-20 7:00 ` [PATCH 1/3] wifi: ath12k: change DMA direction while mapping reinjected packets P Praneesh
2024-05-20 23:38 ` Jeff Johnson
2024-05-25 8:57 ` Kalle Valo
2024-05-20 7:00 ` [PATCH 2/3] wifi: ath12k: fix invalid memory access while processing fragmented packets P Praneesh
2024-05-20 23:38 ` Jeff Johnson
2024-05-20 7:00 ` [PATCH 3/3] wifi: ath12k: fix firmware crash during reo reinject P Praneesh
2024-05-20 23:38 ` Jeff Johnson
2024-05-21 8:50 ` Nicolas Escande
2024-05-22 6:59 ` Ping-Ke Shih [this message]
2024-05-22 7:15 ` Praneesh P
2024-05-22 7:28 ` Nicolas Escande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d276dbb98e1d4b82ada054e1e54f48e8@realtek.com \
--to=pkshih@realtek.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nico.escande@gmail.com \
--cc=quic_ppranees@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).