From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE50C32772 for ; Fri, 19 Aug 2022 17:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349796AbiHSR4T (ORCPT ); Fri, 19 Aug 2022 13:56:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351875AbiHSRzf (ORCPT ); Fri, 19 Aug 2022 13:55:35 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22FFC10228D for ; Fri, 19 Aug 2022 10:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=nDYQHSpmiLl1/ragWnSJn7Ry61REEHBIrGbQHrUMEsQ=; t=1660930597; x=1662140197; b=P9+ovUOgbrCEePeoDbsfC/Fss/rwLPx+Gp2N7vRotB9eCgi dkfvb15gTQF62NgZ7W2f2sGfCMJNfqM1pko5N5piUHarJ+7YmqXQnuQ8VZ7gs1t2M8JpBHkXjUh7T /DWpfIkQKAlvAjtB35apOFf0v3bYaZ0uhq8mDhtnOGMZkumEUJpIFGPLEr3sgwByzPGitAAHTS1yw Orf/DjiVe4DIHRVW1IMpEZzWrKHarMR6hQjDRbx16dXdtnMW/B9AGmo8bFOwRzvMzq6LWYO83WD+n P/mLen/P47jnVMk2M5ZiJg1ikQ7TNlgY7WJLmfB4JnQJJqPatoXqIF7wjl6PpT9A==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1oP5v0-00C72f-2M; Fri, 19 Aug 2022 19:36:26 +0200 Message-ID: Subject: Re: [PATCH 1/9] wifi: mac80211: allow enabling chanctx until hw registration From: Johannes Berg To: Sean Wang Cc: Sean Wang =?UTF-8?Q?=28=E7=8E=8B=E5=BF=97=E4=BA=98=29?= , Felix Fietkau , lorenzo.bianconi@redhat.com, Soul.Huang@mediatek.com, YN.Chen@mediatek.com, Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com, Deren Wu , km.lin@mediatek.com, jenhao.yang@mediatek.com, robin.chiu@mediatek.com, Eddie.Chen@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com, ted.huang@mediatek.com, Stella.Chang@mediatek.com, Tom.Chou@mediatek.com, steve.lee@mediatek.com, jsiuda@google.com, frankgor@google.com, kuabhs@google.com, druth@google.com, abhishekpandit@google.com, shawnku@google.com, linux-wireless@vger.kernel.org, "moderated list:ARM/Mediatek SoC support" Date: Fri, 19 Aug 2022 19:36:25 +0200 In-Reply-To: <096c975e7287cbe22fd355bcfd4b3889c890bdc7.camel@sipsolutions.net> References: <473fc7b169f288b7815a7736cf33ac0ec1599a09.1660606893.git.objelf@gmail.com> <5b24421363048bff1a9f03174cb0223b3e226bf9.camel@sipsolutions.net> <096c975e7287cbe22fd355bcfd4b3889c890bdc7.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2022-08-19 at 19:16 +0200, Johannes Berg wrote: > Hi Sean, >=20 > > > If we really, really need to allow changing the ops, then we should > > > probably make a much larger change to not even pass the ops until > > > register, though I'm not really sure it's worth it just to have mt792= 1 > > > avoid loading the firmware from disk before allocation? >=20 > > Thanks for your input. I thought I'd try to write a patch to follow up > > on the idea you mentioned here. > >=20 >=20 > I think you will introduce a bug into mt7921 when you do this, and I'm > curious if you will find it ;-) >=20 Actually, no, clearing WIPHY_FLAG_IBSS_RSN in mt7921_init_wiphy() actually does nothing, I thought it was required. Anyway, the point is that now we set some defaults in alloc_hw(), some based on the ops, and then the driver could override those before it does register_hw(). With the proposed change, that's no longer possible, and I'm not sure I (or you) would want to audit each and every driver - WIPHY_FLAG_IBSS_RSN was something that showed up easily in grep though. So I still think you're better off doing it in the firmware file :-) johannes