Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: jeff.chen_1@oss.nxp.com, linux-wireless@vger.kernel.org
Cc: francesco@dolcini.it, Jeff Chen <jeff.chen_1@nxp.com>
Subject: Re: [PATCH 1/2] wifi: nxpwifi: add TX power limit host command support
Date: Thu, 01 Oct 2026 12:08:27 +0200	[thread overview]
Message-ID: <d334f65d400f5b5216970e1820f1911f031f8546.camel@sipsolutions.net> (raw)
In-Reply-To: <20261001100640.2829946-2-jeff.chen_1@oss.nxp.com>

On Thu, 2026-10-01 at 18:06 +0800, jeff.chen_1@oss.nxp.com wrote:
> 
> +/* Host-side helper for the channel TRPC (TX power limit) command.
> + * This is not a firmware wire structure; @len counts the bytes from
> + * @action onwards (action + subband + tlvbuffer).
> + */
> +struct nxpwifi_ds_chan_trpc_cfg {
> +	u32 len;
> +	u16 action;
> +	u16 subband;
> +	u8 tlvbuffer[];

If this isn't a FW struct,

> +++ b/drivers/net/wireless/nxp/nxpwifi/fw.h
> ...
> @@ -2373,6 +2374,12 @@ struct host_cmd_twt_cfg {
>  	u8 val[];
>  } __packed;
>  
> +struct host_cmd_chan_trpc_cfg {
> +	u16 action;
> +	u16 subband;
> +	u8 tlvbuffer[];
> +} __packed;

then surely this is (indicated by the file and __packed), and should be
__le16?

johannes

  reply	other threads:[~2026-10-01 10:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 10:06 [PATCH 0/2] wifi: nxpwifi: add TX power limit configuration support jeff.chen_1
2026-10-01 10:06 ` [PATCH 1/2] wifi: nxpwifi: add TX power limit host command support jeff.chen_1
2026-10-01 10:08   ` Johannes Berg [this message]
2026-10-01 10:06 ` [PATCH 2/2] wifi: nxpwifi: add netlink vendor command for TX power limits jeff.chen_1
2026-10-01 10:10   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d334f65d400f5b5216970e1820f1911f031f8546.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=francesco@dolcini.it \
    --cc=jeff.chen_1@nxp.com \
    --cc=jeff.chen_1@oss.nxp.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox