From: Ben Greear <greearb@candelatech.com>
To: akolli@codeaurora.org
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath11k: Allow debugfs to work with 2+ radios installed.
Date: Fri, 4 Sep 2020 08:34:38 -0700 [thread overview]
Message-ID: <d450eb2d-5c2d-c432-2cd5-b3121c7d27d4@candelatech.com> (raw)
In-Reply-To: <0101017459a1d409-4d95a8e1-d404-4fba-a25d-b2e3075947e0-000000@us-west-2.amazonses.com>
On 9/4/20 8:00 AM, akolli@codeaurora.org wrote:
> On 2020-09-03 22:53, greearb@candelatech.com wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> The code is trying to create an ath11k directory on debugfs
>> root, but that fails when there is a second radio (and thus
>> second instance of the driver).
>>
>
> Hi Ben,
>
> IPQ8074 is soc and it does not need second debugfs entry, its on AHB.
> QCA6390 is a pci card and multiple debug entries are needed if multiple cards are available,
> I am planning to post a patch with bus specific abstraction function which creates single debugfs for soc based radios and multiple entries for PCI based radios.
>
> AHB:
> debugfs/ath11k/IPQ8074/
>
> PCI
> debugfs/ath11k/QCA6390_0001:01:00.0/
> debugfs/ath11k/QCA6390_0000:01:00.0/
I appreciate your feedback on this!
Why not just stick with the way ath10k does, having the ath11k debugfs entry be
under the phy debugfs directory?
Maybe there is a high-level design document for the ath11k driver somewhere that
explains how and why it is architected with the ath11k base object holding multiple
phy objects?
And, very curious to know if you are able to get multiple QCA6390 NICs running on the
same system, I'm seeing all sort of problems including NICs not always showing up in lspci
and such.
Thanks,
Ben
>
> Thanks
> Anil
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2020-09-04 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 17:23 [PATCH] ath11k: Allow debugfs to work with 2+ radios installed greearb
2020-09-04 15:00 ` akolli
2020-09-04 15:34 ` Ben Greear [this message]
2020-09-04 16:49 ` akolli
2020-09-04 16:57 ` Ben Greear
2020-09-04 17:45 ` akolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d450eb2d-5c2d-c432-2cd5-b3121c7d27d4@candelatech.com \
--to=greearb@candelatech.com \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox