From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
jjohnson@kernel.org
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
ath11k@lists.infradead.org, linux-kernel@vger.kernel.org,
mani@kernel.org, Alex Williamson <alex@shazbot.org>
Subject: Re: [PATCH 1/2] wifi: ath11k: Flush the posted write after writing to PCIE_SOC_GLOBAL_RESET
Date: Fri, 3 Jul 2026 15:03:08 +0800 [thread overview]
Message-ID: <d492b10a-7445-48df-b752-726e5c02f5be@oss.qualcomm.com> (raw)
In-Reply-To: <20260623141649.41087-1-manivannan.sadhasivam@oss.qualcomm.com>
On 6/23/2026 10:16 PM, Manivannan Sadhasivam wrote:
> ath11k_pci_soc_global_reset() tries to reset the device by writing to the
> PCIE_SOC_GLOBAL_RESET register. But it doesn't do a read-back to ensure
> that the write gets flushed to the device before the delay.
>
> This may lead to the delay on the host to be insufficient, if the posted
> write doesn't reach the device before the delay.
>
> So add a read-back after writing to the PCIE_SOC_GLOBAL_RESET register and
> before the delay.
>
> Compile tested only.
>
> Fixes: f3c603d412b3 ("ath11k: reset MHI during power down and power up")
> Reported-by: Alex Williamson <alex@shazbot.org>
> Closes: https://lore.kernel.org/linux-pci/20260622160822.09350246@shazbot.org
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
prev parent reply other threads:[~2026-07-03 7:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 14:16 [PATCH 1/2] wifi: ath11k: Flush the posted write after writing to PCIE_SOC_GLOBAL_RESET Manivannan Sadhasivam
2026-06-23 14:16 ` [PATCH 2/2] wifi: ath12k: " Manivannan Sadhasivam
2026-06-30 9:43 ` Raj Kumar Bhagat
2026-06-30 9:54 ` Raj Kumar Bhagat
2026-07-03 7:03 ` Baochen Qiang
2026-06-30 9:45 ` [PATCH 1/2] wifi: ath11k: " Raj Kumar Bhagat
2026-07-03 7:03 ` Baochen Qiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d492b10a-7445-48df-b752-726e5c02f5be@oss.qualcomm.com \
--to=baochen.qiang@oss.qualcomm.com \
--cc=alex@shazbot.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox