Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

[Jes Sorensen <jes.sorensen@gmail.com>]

On 03/30/2017 03:15 AM, Greg Kroah-Hartman wrote:
> On Wed, Mar 29, 2017 at 08:20:19PM -0500, Larry Finger wrote:
>> On 03/29/2017 12:47 PM, Hans de Goede wrote:
>>> The rtl8723bs is found on quite a few systems used by Linux users,
>>> such as on Atom systems (Intel Computestick and various other
>>> Atom based devices) and on many (budget) ARM boards such as
>>> the CHIP.
>>>
>>> The plan moving forward with this is for the new clean,
>>> written from scratch, rtl8xxxu driver to eventually gain
>>> support for sdio devices. But there is no clear timeline
>>> for that, so lets add this driver included in staging for now.
>>>
>>> Cc: Bastien Nocera <hadess@hadess.net>
>>> Cc: Larry Finger <Larry.Finger@lwfinger.net>
>>> Cc: Jes Sorensen <jes.sorensen@gmail.com>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Hans,
>>
>> I am still building the driver on my CherryTrail tablet, but I did see some
>> warnings and errors listed by Smatch as follows:
>>
[snip]
>> The indent problems can probably be ignored, but many of the others are
>> serious enough to be addressed now.
>>
>> Once this driver is merged into staging, the Outreachy folks will be really busy.
>>
>> Thanks for posting this driver,
>
> So, no objection from you?  Great, I'll go queue it up later today...
>
> thanks,
>
> greg k-h
>

As much as I hate adding more Realtek vendor code to the kernel, I do 
agree this is the right thing to do in the interim. Not sure when I'll 
get to SDIO support in rtl8xxxu, but I will process patches, hint hint :)

Jes