Re: [REGRESSION] iwlwifi resume error, bisected

["Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>]

On Sat, 2024-09-07 at 22:21 +0100, Chris Bainbridge wrote:
> On Sat, 7 Sept 2024 at 19:35, Grumbach, Emmanuel
> <emmanuel.grumbach@intel.com> wrote:
> > 
> > Can you please try to add:
> > https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git/commit/?id=094513f8a2fbddee51b055d8035f995551f98fce
> > https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git/commit/?id=cb347bd29d0d106213a0cf4f86b72dffd08d3454
> > 
> > and let me know if things work again for you?
> 
> Both of those patches are already in v6.11-rc6 (which has the error).

Can you please try to apply this:

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
index 1822e22b7c0a..454eb1155881 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
@@ -1697,6 +1697,8 @@ int iwl_trans_pcie_d3_resume(struct iwl_trans *trans,
 out:
        if (*status == IWL_D3_STATUS_ALIVE)
                ret = iwl_pcie_d3_handshake(trans, false);
+       else
+               trans->state = IWL_TRANS_NO_FW;
 
        return ret;
 }

It should fix the last part of the error you pasted:

[  103.512122] iwlwifi 0000:01:00.0: Hardware error detected. Restarting.
[  103.512330] iwlwifi 0000:01:00.0: Start IWL Error Log Dump:
[  103.512331] iwlwifi 0000:01:00.0: Transport status: 0x0000004B

You'll still have the first part but I expect WiFi to work.
I'm still checking internally what we need to do here.

Thanks for your report and bisection!

> 
> > BTW - I assume that your system is configured not to power the WLAN device if the power cord is
> > not
> > connected and the system is suspended?
> 
> This is a HP laptop with default BIOS settings. It's possible that the
> HP BIOS turns off the wifi when suspended on battery power, but I
> haven't explicitly configured anything related to WLAN power (I don't
> see any BIOS settings for that), and the kernel is running with
> default parameters.

I see. Thanks.