From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3CDC433DB for ; Wed, 27 Jan 2021 04:59:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A38082068D for ; Wed, 27 Jan 2021 04:59:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239726AbhA0E7U (ORCPT ); Tue, 26 Jan 2021 23:59:20 -0500 Received: from a1.mail.mailgun.net ([198.61.254.60]:59454 "EHLO a1.mail.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231231AbhA0CtZ (ORCPT ); Tue, 26 Jan 2021 21:49:25 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1611715735; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=qw/kVL84SAVbHjsbqYNnOyC+Y4xO3RhPA7uTRHVZgAg=; b=l0qUT3oF6zWkcAw+cL6hLQVHece7fD9/NahTAGipHF9IMHqRnw4HbWQVh5STDt8G9D/bMKHi +ZxaUl8ibBM6U3zU/ST71zAcjmPRb+AcBN+cA5j4xWDkejUF3IkpvGdRA2yqb7TTylzFUvkg Q20Tjd4Pv9AsCwDMi/fFoxkpe1Q= X-Mailgun-Sending-Ip: 198.61.254.60 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 6010d409ad4c9e395b73e32f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 27 Jan 2021 02:46:33 GMT Sender: periyasa=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 34236C43463; Wed, 27 Jan 2021 02:46:33 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: periyasa) by smtp.codeaurora.org (Postfix) with ESMTPSA id BFAEDC433C6; Wed, 27 Jan 2021 02:46:32 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 27 Jan 2021 08:16:32 +0530 From: Karthikeyan periyasamy To: Peter Oh Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH] ath11k: Update tx descriptor search index properly In-Reply-To: <959ea12a-e35b-5867-c55e-7f62e2956b09@eero.com> References: <1608305041-21946-1-git-send-email-periyasa@codeaurora.org> <959ea12a-e35b-5867-c55e-7f62e2956b09@eero.com> Message-ID: X-Sender: periyasa@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-12-19 00:53, Peter Oh wrote: > On 12/18/20 7:24 AM, Karthikeyan Periyasamy wrote: >> Tx descriptor search index field should be updated with hw peer id >> and not by AST Hash. Incorrect search index causes throughput >> degradation >> in all the platforms. so updated the search index field with hw peer >> id, >> which is a common change applicable for all the platforms. >> >> Tested-on: IPQ8074 hw2.0 AHB >> WLAN.HK.2.4.0.1-01492-QCAHKSWPL_SILICONZ-1 >> >> diff --git a/drivers/net/wireless/ath/ath11k/peer.c >> b/drivers/net/wireless/ath/ath11k/peer.c >> index b69e7eb..f49abefa 100644 >> --- a/drivers/net/wireless/ath/ath11k/peer.c >> +++ b/drivers/net/wireless/ath/ath11k/peer.c >> >> @@ -309,7 +310,11 @@ int ath11k_peer_create(struct ath11k *ar, struct >> ath11k_vif *arvif, >> peer->pdev_idx = ar->pdev_idx; >> peer->sta = sta; >> - arvif->ast_hash = peer->ast_hash; >> + >> + if (arvif->vif->type == NL80211_IFTYPE_STATION) { >> + arvif->ast_hash = peer->ast_hash; >> + arvif->ast_idx = peer->hw_peer_id; >> + } > > How about non STATION type? > no need of configuring the ast_idx, ast_hash field for non station type. Its recommended by HW/FW team. Thanks, Karthikeyan P