From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4CA7401A2B for ; Wed, 25 Mar 2026 17:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774458915; cv=none; b=sXe+SZ1/dLcrP3/S6iT04zfINkPszKYnXAz4ZKQmimkvsPz6Nu5S6C/8r4NBdoIqWeB8mpJZEXut+wFtRwXwGOD0WXwSnxvj6m1VCMP9hmLc4d/ptZA612zif9MsOG8WnSDCEAwvYoGFQIfThdOLSRLVdTA7IOJgRvJJW+O69Qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774458915; c=relaxed/simple; bh=uwcLVO/gOjkC3WYajEHlZW3aMp9aoyle84fdStwt6C4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JzXxGgmtmBwHhI55oXDNfTE0R4Qxh5HOLQhNAyr20oV3tuvVkjQdcfBMf9wG1AcU04XbaBc10BBuoL30fHVjJFK8BbaSL/uAkWiRYxYF7OzHgy7ZDUMQgSx0yUsE8TVW1gokFR3DJDaZ5ki+cYN7qTwghafEyfHxWJ9KUp/74l8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oEBOlUi5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ea8swqz4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oEBOlUi5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ea8swqz4" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PFHM1k433827 for ; Wed, 25 Mar 2026 17:15:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=MxtnUbf8avEpC6Wnx92MUbMm n0aJDZVFQp0HMpGDqRE=; b=oEBOlUi5RxHgUWqiMkM9jB976WTJSlN05eouAEJv d5ehr5uFb0BUA3pSwd4BaiAWrtaeZHAMdvq26mW+MBl+W/6kmDoRVU5pQ9x5zVqt /8fHL7zLxs0MzogHOIxf39CoT2VkZ2fRMlNF+48YZNMA87E1SoDGVoRgNQOspFMP t1WGfLRFX+ReGb/Zxnkskgtrn6jYnJiS+HvYge0E1whPiRODGOgHNtVX+y7dm2k4 znq/AXWWLoIS+88CeLvWNR88n9SC3rqbG0pk6pZY9wEGCXKo2AbqjrYOuJzqG5pk P+2r6LUlDon+kT/7IFKynPNL5uwAWdie2g1q5p2QI2qBBA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d41414787-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 17:15:13 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5094ba09affso4377551cf.2 for ; Wed, 25 Mar 2026 10:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774458912; x=1775063712; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MxtnUbf8avEpC6Wnx92MUbMmn0aJDZVFQp0HMpGDqRE=; b=ea8swqz42Ma8csEWzr0MeZ8tSB2A2aoxhrdSO2m/Zy1a6LTBg9Keukk+RxlehRL8c/ ie2DtuBnCmDCasj5PXnWUZwZYcdsDBouCCE+cuM93Ncnx04I7jC0KR5Nztwc3BvCeY6m Z+/NLJFG8wYUwy38+yvjwN4SEmvRf9NS/JNFu3ZUwwEth9Z6xog49tMjqTEGVTYuEc6F lNZoL5WmqfIG+oDpnFqbNM4r3ADduDCWnGhOjR7F9Mb4NBOCIS/EbjCFyaTQVBjVucDs kB9lske/BFFlVtXVXe7GR4xDZ7kZT0kXz9QziTnmbF9dqK2c8KFs7wHs5x8aC3XdeoH2 Kolw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774458912; x=1775063712; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MxtnUbf8avEpC6Wnx92MUbMmn0aJDZVFQp0HMpGDqRE=; b=nIhLQ2aD0evW22Waybt0mGzlJuW45MtHyUID7zddRcJz7Ws3UiiUlwH5i4dUul/zkC GoXB/uQgsl2kzTGNLvLgDKJhOtYMtSoC6A1x3qZGicKH9uWGsCahcpyAbnZZo+ANQfWJ DLNja++eflCCdHlSurZK4lHl34Lw5OxnXin3a7Kc0OVjGwiP3PBaqnidGtJtZo8ycaas WH+IzAjr0azSD3au4RbMVGQTyhFrI4+e7nkL5Wteaa8AVH0OIlOsnndKGGEbllH+CdL3 +XoptFZdTB8ePFqSYywbb51h3E5OufOqit7splXLGeNETb1d+cCiV6vgEWr4YsRD5GZN zKzw== X-Forwarded-Encrypted: i=1; AJvYcCXz978NEyzzrZdHW0VWs/esoHKK/rB0BtaZ6O1ASb65A8Rmu8axfxGs3MCRd7Y87Mpc2ZXd4kgHUZHZ0S5EMw==@vger.kernel.org X-Gm-Message-State: AOJu0Yzbdh/qt+luH2R8OSO0i247sVd6Hi8o+y1FDZJ+pBadSJvKH4XS S67ccJtzwEkqa1XQUyWaDtjbl6NgTHCkjrhzztTg4Gc6I07OgWre5/DZhJ4/M45JxUAZE8AB1pC DI10r3O5IcJm5qd4u7Np9tXUZPTNQ1WB80so8NyswZzvlH0mgLv3kGhC0CXHWTWsMZaPX1Q== X-Gm-Gg: ATEYQzyWhmj0aId09jYL8S+9pE51lDpHV23yqXaeqKkKStydm1piyk11xB5K/LRpZ8h GeoYTqw/fJofeMR8PfLmWGgVpEWOuqhnKwL/hY1SjRE1g9F01fSVfEtvAOXLWlS1YUeh+UcyY6u WpkBqUxnJsPrw55g96LMo+a78cqK0nNoQzWMIntQYjdxQYlgvKkfLvL1labqwoGRPJ1Gu5DiBq0 iuv3MlMSZfzTsQF5nnCpVlhIVRq3ohRE7Awu2foFDKNIy3fnh+TR7ALJ2/G9AwNhYj/7/hG0SJi 4XW6/ski+Q1P5cHtnlBn5LyCKG1/ww0m9Qlli5EO0PRRykaLb0dUtN31GtkWGKEr+YU7mzARcs3 lYMz9BuVhG13Iu1mNEWJUUf3WXu4Xg/Q99nl3n4FJ1NxhqKcqy6C5Be7NDPOEc8dgGr1j5EtLi7 r/PDuRNyaKNZuSn1clDadEG1//FLYuzCuejo4= X-Received: by 2002:a05:622a:11c7:b0:50b:3d9f:384e with SMTP id d75a77b69052e-50b80e32741mr61511751cf.44.1774458912078; Wed, 25 Mar 2026 10:15:12 -0700 (PDT) X-Received: by 2002:a05:622a:11c7:b0:50b:3d9f:384e with SMTP id d75a77b69052e-50b80e32741mr61510701cf.44.1774458911390; Wed, 25 Mar 2026 10:15:11 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2a06a5e90sm25519e87.83.2026.03.25.10.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 10:15:10 -0700 (PDT) Date: Wed, 25 Mar 2026 19:15:08 +0200 From: Dmitry Baryshkov To: david@ixit.cz Cc: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Johnson , Bjorn Andersson , Konrad Dybcio , Paul Sajna , Amit Pundir , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH v3 2/3] ath10k: Introduce a device-tree quirk to skip host cap QMI requests Message-ID: References: <20260325-skip-host-cam-qmi-req-v3-0-b163cf7b3c81@ixit.cz> <20260325-skip-host-cam-qmi-req-v3-2-b163cf7b3c81@ixit.cz> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260325-skip-host-cam-qmi-req-v3-2-b163cf7b3c81@ixit.cz> X-Authority-Analysis: v=2.4 cv=fOk0HJae c=1 sm=1 tr=0 ts=69c41821 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=2Fa2QF5d3zqJHI2iiAMA:9 a=CjuIK1q_8ugA:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: yLA6B6QTkmdH0csjcGqkajYrAZjJXySu X-Proofpoint-ORIG-GUID: yLA6B6QTkmdH0csjcGqkajYrAZjJXySu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDEyNSBTYWx0ZWRfX+Sgjv0QpocpC Hq00tItanrGF6YrO2fNoQsoCW8M161jWoIrycFS/1WDBRD1B0qxdTOja8Umw6dp5B45juAwN74p L8JEisddGbm/uHfP5hjJZ6AkoMM3L7M80FDXuG4eEaEB9wChoRbyrT20mhYrLgLkzRPE80qZgqc aV13xvqFx+hHdlCdsFF5dKPdawFsdiqGmfoPMnIAn/JRe9qh+UP4xrDunwD2WWX/30ZMwqg9JJI jQVbn1f23r/+ArSIN7/jq3MnmWa0g5GF+Oj3RIqF7JWtxod6kl9eG05d23e/Wb2m7Hsjx5GGRRY Eo7bry9H9VG6s8lf8zCWgBpWxvY2O7zTg5LLpe259AyI8y8YN9lfwNEiyQNFC0gXyJ71S5WyaiO wJ5nT2xT02ZXoU2rCjMlsxkfn4KiRNpiW1CpXR96R1TTWZESKNUrJDz74XZlC8QbOxudNt3dv39 YAjyPMRmOZiARomHFzA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_05,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 priorityscore=1501 clxscore=1015 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250125 On Wed, Mar 25, 2026 at 05:41:13PM +0100, David Heidelberg via B4 Relay wrote: > From: Amit Pundir > > There are firmware versions which do not support host capability QMI > request. We suspect either the host cap is not implemented or there may > be firmware specific issues, but apparently there seem to be a generation > of firmware that has this particular behavior. It needs to be explicit that this happens _before_ firmware-N.bin and board-M.bin loading. As such, you can't add a quirk to the firmware.bin (a standard way to handle firmware issues). > For example, firmware build on Xiaomi Poco F1 (sdm845) phone: > "QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c3-00257-QCAHLSWMTPLZ-1" > > If we do not skip the host cap QMI request on Poco F1, then we get a > QMI_ERR_MALFORMED_MSG_V01 error message before loading the firmware in the > ath10k_qmi_host_cap_send_sync(). This error message is not fatal to the > firmware nor to the ath10k driver and we can still bring up the WiFi > services successfully if we just ignore it. > > Hence introducing this device-tree quirk to skip host capability > QMI request for the devices with firmware versions which do not support > this feature. > > Suggested-by: Bjorn Andersson > Signed-off-by: Amit Pundir You are sending the patch, but it misses your SoB. > --- > drivers/net/wireless/ath/ath10k/qmi.c | 13 ++++++++++--- > drivers/net/wireless/ath/ath10k/snoc.c | 3 +++ > drivers/net/wireless/ath/ath10k/snoc.h | 1 + > 3 files changed, 14 insertions(+), 3 deletions(-) -- With best wishes Dmitry