public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Fedor Pchelkin <pchelkin@ispras.ru>,
	Zong-Zhe Yang <kevin_yang@realtek.com>
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	Bernie Huang <phhuang@realtek.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: RE: [PATCH rtw v4 3/4] wifi: rtw89: fix leak in rtw89_core_send_nullfunc()
Date: Thu, 18 Sep 2025 05:48:58 +0000	[thread overview]
Message-ID: <d7305c1e34ea4889869d27b43273d5c6@realtek.com> (raw)
In-Reply-To: <20250917095302.2908617-4-pchelkin@ispras.ru>

Fedor Pchelkin <pchelkin@ispras.ru> wrote:
> If there is no rtwsta_link found in rtw89_core_send_nullfunc(), allocated
> skb is leaked.  Free it on the error handling path.
> 
> Found by Linux Verification Center (linuxtesting.org).
> 
> Fixes: a8ba4acab7db ("wifi: rtw89: send nullfunc based on the given link")
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>


  reply	other threads:[~2025-09-18  5:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17  9:52 [PATCH rtw v4 0/4] wifi: fixes for rtw89 Fedor Pchelkin
2025-09-17  9:52 ` [PATCH rtw v4 1/4] wifi: rtw89: fix use-after-free in rtw89_core_tx_kick_off_and_wait() Fedor Pchelkin
2025-09-18  4:00   ` Ping-Ke Shih
2025-09-18  4:40     ` Zong-Zhe Yang
2025-09-18  5:23       ` Ping-Ke Shih
2025-09-18 13:34         ` Fedor Pchelkin
2025-09-19  0:27           ` Ping-Ke Shih
2025-09-17  9:52 ` [PATCH rtw v4 2/4] wifi: rtw89: fix tx_wait initialization race Fedor Pchelkin
2025-09-18  5:47   ` Ping-Ke Shih
2025-09-18 15:19     ` Fedor Pchelkin
2025-09-19  0:34       ` Ping-Ke Shih
2025-09-19  0:50         ` Ping-Ke Shih
2025-09-19  7:46           ` Fedor Pchelkin
2025-09-17  9:52 ` [PATCH rtw v4 3/4] wifi: rtw89: fix leak in rtw89_core_send_nullfunc() Fedor Pchelkin
2025-09-18  5:48   ` Ping-Ke Shih [this message]
2025-09-17  9:52 ` [PATCH rtw v4 4/4] wifi: rtw89: avoid circular locking dependency in ser_state_run() Fedor Pchelkin
2025-09-18  5:52   ` Ping-Ke Shih
2025-09-18 15:30     ` Fedor Pchelkin
2025-09-19  0:46       ` Ping-Ke Shih
2025-09-19 11:00         ` Fedor Pchelkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7305c1e34ea4889869d27b43273d5c6@realtek.com \
    --to=pkshih@realtek.com \
    --cc=kevin_yang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=pchelkin@ispras.ru \
    --cc=phhuang@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox