From: michael-dev <michael-dev@fami-braun.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: projekt-wlan@fem.tu-ilmenau.de, Fietkau <nbd@openwrt.org>,
Felix@mail.fem.tu-ilmenau.de, linux-wireless@vger.kernel.org
Subject: Re: [Projekt-wlan] [PATCHv5 2/2] mac80211: fix A-MSDU outer SA/DA
Date: Mon, 17 Oct 2016 12:29:40 +0200 [thread overview]
Message-ID: <d793195b149aebb974dd596632d2ba83@fami-braun.de> (raw)
In-Reply-To: <1476697463.19992.18.camel@sipsolutions.net>
Am 17.10.2016 11:44, schrieb Johannes Berg:
>> + if (bssid && ieee80211_has_fromds(hdr->frame_control))
>> + memcpy(h_80211_src, bssid, ETH_ALEN);
>> +
>> + if (bssid && ieee80211_has_tods(hdr->frame_control))
>> + memcpy(h_80211_dst, bssid, ETH_ALEN);
>
> but I also changed these to ether_addr_copy()
ether_addr_copy requires both arguments to be __aligned(2) according to
include/linux/etherdevice.h.
bssid might be sdata->u.mgd.bssid, which is bssid in struct
ieee80211_if_managed, but neither sdata->u, sdata->u.mgd nor
sdata->u.mgd.bssid seem to be declared as __aligned(2).
So ether_addr_copy should not be used.
What am I missing?
Regards,
M. Braun
next prev parent reply other threads:[~2016-10-17 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 11:28 [PATCHv5 1/2] mac80211: avoid extra memcpy in A-MSDU head creation Michael Braun
2016-10-15 11:28 ` [PATCHv5 2/2] mac80211: fix A-MSDU outer SA/DA Michael Braun
2016-10-17 9:44 ` Johannes Berg
2016-10-17 10:29 ` michael-dev [this message]
2016-10-17 10:39 ` [Projekt-wlan] " Johannes Berg
2016-10-17 9:41 ` [PATCHv5 1/2] mac80211: avoid extra memcpy in A-MSDU head creation Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d793195b149aebb974dd596632d2ba83@fami-braun.de \
--to=michael-dev@fami-braun.de \
--cc=Felix@mail.fem.tu-ilmenau.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
--cc=projekt-wlan@fem.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).