From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88281ECDE3B for ; Wed, 17 Oct 2018 20:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50D702087A for ; Wed, 17 Oct 2018 20:56:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50D702087A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727396AbeJREyL (ORCPT ); Thu, 18 Oct 2018 00:54:11 -0400 Received: from mga05.intel.com ([192.55.52.43]:54661 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbeJREyL (ORCPT ); Thu, 18 Oct 2018 00:54:11 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 13:56:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,393,1534834800"; d="scan'208";a="100115536" Received: from jprestwo.jf.intel.com ([10.54.74.38]) by fmsmga001.fm.intel.com with ESMTP; 17 Oct 2018 13:56:42 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] mac80211_hwsim: allow setting iftype support From: James Prestwood To: Johannes Berg , linux-wireless@vger.kernel.org Date: Wed, 17 Oct 2018 14:00:23 -0700 In-Reply-To: <48e12e055637af139094b6c1163f61c45b5ebb54.camel@sipsolutions.net> References: <20181017193307.1780-1-james.prestwood@linux.intel.com> <20181017193307.1780-2-james.prestwood@linux.intel.com> (sfid-20181017_212933_830456_E841649D) <48e12e055637af139094b6c1163f61c45b5ebb54.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2018-10-17 at 21:53 +0200, Johannes Berg wrote: > On Wed, 2018-10-17 at 12:33 -0700, James Prestwood wrote: > > The mac80211_hwsim driver hard codes its supported interface types. > > For > > testing purposes it would be valuable to allow changing these > > supported > > types in order to simulate actual drivers than support a limited > > set of > > typo: than -> that > > > In order to accomplish this, the ieee80211_iface_limit structure > > needed > > to be built dynamically to only include limit rules for iftypes > > that > > the user requested to enable. > > That makes me wonder if you'd also want to support limiting the # of > interfaces/channels to mimic another device? Yeah it seems like it would be pretty easy to add that on top of this change, although I don't really see us actually using it. I can add it, but my only concern is I would not test it up to the same level I tested iftype/ciphers. Maybe this is also because I am not entirely sure what num_different_channels is doing. Is this only relevant when multiple interfaces exist on a radio? Like setting how many channels can be use simultaneously? > > johannes >