RE: [PATCH] wifi: rtl8xxxu: Support new chip RTL8710BU aka RTL8188GU

[Ping-Ke Shih <pkshih@realtek.com>]

> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Sent: Wednesday, February 22, 2023 2:50 AM
> To: Ping-Ke Shih <pkshih@realtek.com>; linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>
> Subject: Re: [PATCH] wifi: rtl8xxxu: Support new chip RTL8710BU aka RTL8188GU
> 
> On 21/02/2023 04:45, Ping-Ke Shih wrote:
> >
> >
> >> -----Original Message-----
> >> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> >> Sent: Tuesday, February 21, 2023 12:11 AM
> >> To: linux-wireless@vger.kernel.org
> >> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>
> >> Subject: [PATCH] wifi: rtl8xxxu: Support new chip RTL8710BU aka RTL8188GU
> >>
> >> +
> >> +       do
> >> +               val32 = rtl8xxxu_read32(priv, REG_EFUSE_INDIRECT_CTRL_8710B);
> >> +       while ((val32 & BIT(31)) && (--polling_count > 0));
> >
> > Without a pair of brace, that looks a little odd to me, but the result should
> > be correct.
> >
> I think the rule is that we should not use braces when there is a single
> line inside. I assumed that applies to do...while loops too.

I give it a try about this, and the results are

checkpatch warns 'while':

+       while (1) {
+               x = 1;
+       }


But, don't warn 'do...while'. (your case)

+       do {
+               x = 1;
+       } while (1);


Looking into checkpatch, I found it checks single statement under these
conditions 'if|while|for|else'.


Ping-Ke