Re: [possible BUG] PM suspend warning in 2.6.29-rc3-00227-gf1dd849

[Ming Lei <tom.leiming@gmail.com>]

2009/2/3 reinette chatre <reinette.chatre@intel.com>:
> Ming,
>
> On Mon, 2009-02-02 at 06:14 -0800, Ming Lei wrote:
>> After applying your patch, following is the dmesg output, so it is the
>> iwl3945 driver that does not save pci state.
>
> Could you please test with the patch below?

reinette,

The previous warning during pm suspending does disappear after
applying your patch.

Thanks!

>
> Thank you
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> index 95d0198..5b44d32 100644
> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> @@ -8143,6 +8143,7 @@ static int iwl3945_pci_suspend(struct pci_dev
> *pdev, pm_message_t state)
>                priv->is_open = 1;
>        }
>
> +       pci_save_state(pdev);
>        pci_set_power_state(pdev, PCI_D3hot);
>
>        return 0;
> @@ -8153,6 +8154,7 @@ static int iwl3945_pci_resume(struct pci_dev
> *pdev)
>        struct iwl3945_priv *priv = pci_get_drvdata(pdev);
>
>        pci_set_power_state(pdev, PCI_D0);
> +       pci_restore_state(pdev);
>
>        if (priv->is_open)
>                iwl3945_mac_start(priv->hw);
>
>
>
>
>



-- 
Lei Ming