From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Amitkumar Karwar <akarwar@marvell.com>
Cc: Nishant Sarmukadam <nishants@marvell.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mwifiex: fix mwifiex_add_virtual_intf()
Date: Sat, 2 Jul 2016 20:00:33 +0200 [thread overview]
Message-ID: <d95186fc-fa1f-b60d-41a9-4d25c7ccc53d@broadcom.com> (raw)
In-Reply-To: <20160702072045.GA25758@mwanda>
On 2-7-2016 9:20, Dan Carpenter wrote:
> We accidentally left some if statements out so the
> mwifiex_add_virtual_intf() function returns early.
>
> Fixes: 7311ea850079 ('mwifiex: fix AP start problem for newly added interface')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Someone beat you to it [1] ;-)
Regards,
Arend
[1]
http://mid.gmane.org/1467401982-18943-1-git-send-email-javier@osg.samsung.com
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index 99e8cf1..5de9f63 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -2865,9 +2865,11 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy,
>
> ret = mwifiex_send_cmd(priv, HostCmd_CMD_SET_BSS_MODE,
> HostCmd_ACT_GEN_SET, 0, NULL, true);
> + if (ret)
> return ERR_PTR(ret);
>
> ret = mwifiex_sta_init_cmd(priv, false, false);
> + if (ret)
> return ERR_PTR(ret);
>
> mwifiex_setup_ht_caps(&wiphy->bands[NL80211_BAND_2GHZ]->ht_cap, priv);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2016-07-02 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 7:20 [patch] mwifiex: fix mwifiex_add_virtual_intf() Dan Carpenter
2016-07-02 18:00 ` Arend Van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d95186fc-fa1f-b60d-41a9-4d25c7ccc53d@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=akarwar@marvell.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox