From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.183 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794138266; b=Y2u9rus6S4ZfOZD1sMvLcQ4Fe0s0apGtU9NGyP+7xml3leSSyIpTWH/sGAwXgugI1uL5 K8oxmIcMz3uTW5ZRM5IthNvPbIX1u9H2zEtg578ncFOo6kmy3hcgufT80ikhxOEJxzLHn IUYSD5AwN8B4/Ayk2ykEG0yhnXLkqD2bCnlLjjJOqoO62T5L5pIVS+fRLkal9XWwKV0Dr BpyLJ+Y28owDI/gXLdkHWyWnxUtb1H6pc9sM8M4BxFzQXOZtMxaN8gVEwrv06+IXthK7G ZpygvXhz6fshjZ52C5yzz9X4qANK2IfaFyn0asmz+SUp8BvZLRb+QWn6ziOLX7wlb+g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794138266; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:MIME-Version:Date:Content-Type: Content-Transfer-Encoding:From:Message-ID:TLS-Required:Subject:To:Cc: In-Reply-To:References; bh=3q/lah2BivF8l6bCIIx5ik0n39T6McQx2xUSAGLT6ik=; b=ZB0/tgNSwtTC219xB9PBdmiTHWuvMQDaLj2D2EbRuXLkCBdO/cVXQ2ozUHStySEO7bB5 /W2BoE6ilS+A5fjgaiu+9Zy1IoT6rSZcdsyv+FpVRj5JP4mEiH3J4Meqx1/wcaSyuT343 7mk/zTxGNaYkZ/74MNA484dk0ia4zZr8z3XEdcYBjLOMMlEswfP/vbyADx7/nBp6rA6IU 0NvYRPPaXjHBcZkh5KrD/eLvk8kyteJYb6V7rcSODToY8kMiHynJJgCxlvWAifIvwZe3Z 8wGT/DvhEVF/vrldlvh5AVPh21guqxJEViOkErZhR8gKa9riRYBa8jDCZA19DSh3p6w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=lgqb8ZXx; arc=none smtp.remote-ip=91.218.175.183 Received: from mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A610B606A321 for ; Sun, 8 Nov 2026 11:44:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A610B606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=lgqb8ZXx X-Envelope-To: linux-wireless@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=NfxEQyvo6YzvwIKDIqYTEEs+dBfaE7g8zWPgpNgj6VE=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794138263; v=1; x=1794743063; b=lgqb8ZXx/vWcpQrPjMMCkz11FrUgmviA9aFeX5K1ANatpUqhjv48SdumDgQdqgk1i7iM58lt TN9xRur7ub72APowfK+7Jl90UEhW5YqXmy2XH/WlhQMkBVxx0X4sPqBL+4n4/KuAWw7KQXTgG8/ xfy2EuwdTX/BUOuQwzFnvTYQ= X-Envelope-To: linux-wireless@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 47e901772c1c05d8; Sun, 08 Nov 2026 11:44:22 +0000 X-Mizu-Trace-ID: 47e901772c1c05d8 X-Migadu-Flow: FLOW_OUT X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Date: Sun, 08 Nov 2026 11:44:22 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Luka Gejak" Message-ID: TLS-Required: No Subject: Re: [PATCH v3 2/2] wifi: rtw88: ps: trigger firmware recovery only after consecutive LPS leave failures To: "Kalpesh Solanki" , pkshih@realtek.com Cc: kvalo@kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "Kalpesh Solanki" In-Reply-To: <20261108085126.331784-3-skalpesh942@gmail.com> References: <20261108085126.331784-1-skalpesh942@gmail.com> <20261108085126.331784-3-skalpesh942@gmail.com> Hi Kalpesh, I also have a couple of comments for this patch. November 8, 2026 at 9:51 AM, "Kalpesh Solanki" wr= ote: > diff --git a/drivers/net/wireless/realtek/rtw88/ps.c b/drivers/net/wire= less/realtek/rtw88/ps.c > index add5a20b8432..864e2be243ea 100644 > --- a/drivers/net/wireless/realtek/rtw88/ps.c > +++ b/drivers/net/wireless/realtek/rtw88/ps.c > @@ -165,7 +165,14 @@ static void rtw_fw_leave_lps_check(struct rtw_dev = *rtwdev) > if (ret) { > rtw_write32_clr(rtwdev, REG_TCR, BIT_PWRMGT_HWDATA_EN); > rtw_warn(rtwdev, "firmware failed to leave lps state\n"); > - rtw_fw_dump_dbg_info(rtwdev); rtw_fw_dump_dbg_info() returns right away unless RTW_DBG_FW is set, so I don't think it can flood the log in normal use, and the rtw_warn() above still prints on every failure. With that debug mask on, the dump from the first failure seems useful too. Could it stay where it was? > + > + rtwdev->ps_hang_cnt++; > + if (rtwdev->ps_hang_cnt >=3D RTW_PS_HANG_MAX_CNT) { > + rtw_fw_dump_dbg_info(rtwdev); > + rtw_fw_recovery(rtwdev); This still reaches USB and SDIO, and as far as I can see __fw_recovery_work() can't run there yet. It clears the keys from an atomic iterator: __fw_recovery_work() rtw_iterate_keys_atomic() ieee80211_iter_keys_atomic() /* holds local->key_lock */ rtw_reset_key_iter() rtw_sec_clear_cam() rtw_write32() On USB that write ends in usb_control_msg() and on SDIO it needs sdio_claim_host(), so I think both sleep with the spinlock held. 78d5bf925f30 ("wifi: rtw88: iterate over vif/sta list non-atomically") moved other iterators away from this for USB, but until now nothing outside PCI could get to the recovery code. Would it be ok to only call rtw_fw_recovery() on PCI for now, with a rtw_hci_type() check? USB and SDIO never had this recovery anyway. This can also run during a disconnect. ieee80211_set_disassoc() leaves LPS before it removes the AP station, so if that is the third failure, the recovery work can remove the station first and rtw_ops_sta_remove() then removes it again. If I read it right, sta_cnt underflows and si->mask is freed twice if a bitrate mask was set. Maybe rtw_sta_remove() could skip a station that was already reset? Best regards, Luka Gejak