Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@iki.fi>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: wireless-testing broken
Date: Wed, 23 Sep 2009 21:39:14 -0700	[thread overview]
Message-ID: <da94abde0909232139t396b37b3x7cfdeaaafbbbcda1@mail.gmail.com> (raw)
In-Reply-To: <da94abde0909232116n4ddc8bedxf7033a140a0c6fa0@mail.gmail.com>

On Wed, Sep 23, 2009 at 9:16 PM, Kalle Valo <kalle.valo@iki.fi> wrote:
> On Wed, Sep 23, 2009 at 8:54 PM, John W. Linville
> <linville@tuxdriver.com> wrote:
>> I know you aren't in a great situation for this, but could you try
>> a bisect?  Or, you might just try reverting "iwlwifi: reduce noise
>> when skb allocation" as a start...
>
> Sure, I'll start bisecting right now.

The result is:

55a00b83339f25d2979b85ab6e2151390327db80 is first bad commit
commit 55a00b83339f25d2979b85ab6e2151390327db80
Author: Johannes Berg <johannes@sipsolutions.net>
Date:   Thu Sep 17 17:15:31 2009 -0700

    cfg80211: don't overwrite privacy setting

    When cfg80211 is instructed to connect, it always
    uses the default WEP key for the privacy setting,
    which clearly is wrong when using wpa_supplicant.
    Don't overwrite the setting, and rely on it being
    false when wpa_supplicant is not running, instead
    set it to true when we have keys.

    Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

I verified the result by manually reverting the commit and this is
really causing my problem. My current setup is debian unstable,
default debian wpa_supplicant (using wext I think, haven't checked)
and open network at Portland Marriott hotel. I can reproduce the
problem every time.

Kalle

  reply	other threads:[~2009-09-24  4:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24  1:00 wireless-testing broken Kalle Valo
2009-09-24  3:54 ` John W. Linville
2009-09-24  4:16   ` Kalle Valo
2009-09-24  4:39     ` Kalle Valo [this message]
2009-09-24  3:55 ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da94abde0909232139t396b37b3x7cfdeaaafbbbcda1@mail.gmail.com \
    --to=kalle.valo@iki.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox