From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223FBC4727C for ; Tue, 29 Sep 2020 12:40:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFA982075F for ; Tue, 29 Sep 2020 12:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="m0URmKYM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730775AbgI2MkX (ORCPT ); Tue, 29 Sep 2020 08:40:23 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:22007 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729212AbgI2Mjw (ORCPT ); Tue, 29 Sep 2020 08:39:52 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601383191; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=qnKjfeAqZgS/wv0jK17vPZZQ8cNXoaFEqYT3pTlsR2o=; b=m0URmKYMELsDzNn46tcoxwRlcafXvQzEXO+bKM5/RgKvP2bEG0Dba76Rzuz7pjgy+IapwuBS Z/B1Vj4+47kwR9EdcWa9lveQ9cXoqqX46xfPawx7RsyaRmZDV+8NmACRIz+eutCgPPLAJgbG 7ZeT2K3BePj7ERCBrgge5MSFKzA= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5f732b1370602555f58d14cd (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 29 Sep 2020 12:39:47 GMT Sender: vnaralas=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2BF4DC433CB; Tue, 29 Sep 2020 12:39:46 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: vnaralas) by smtp.codeaurora.org (Postfix) with ESMTPSA id C9798C433A0; Tue, 29 Sep 2020 12:39:44 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 29 Sep 2020 18:09:44 +0530 From: vnaralas@codeaurora.org To: Kalle Valo Cc: Johannes Berg , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save In-Reply-To: <871rilf2th.fsf@codeaurora.org> References: <1598257589-19091-1-git-send-email-vnaralas@codeaurora.org> <4b4a0d79a243c1c3b8044730da0493c96ba294bf.camel@sipsolutions.net> <871rilf2th.fsf@codeaurora.org> Message-ID: X-Sender: vnaralas@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-09-29 13:10, Kalle Valo wrote: > Johannes Berg writes: > >> On Mon, 2020-08-24 at 13:56 +0530, Venkateswara Naralasetty wrote: >>> AP power save feature is to save power in AP mode, where AP goes >>> to power save mode when no stations associate to it and comes out >>> of power save when any station associate to AP. >> >> Why do you think this requires a vendor command? I mean, that seems >> like >> fairly reasonable - even by default - behaviour? > > I have not studied the details, but doesn't AP power save break normal > functionality? For example, I would guess probe requests from clients > would be lost. So there's a major drawback when enabling this, right? This AP power save feature will not break any functionality, Since one chain is always active and all other chains will be disabled when this feature is enabled. AP can still be able to beacon and receive probe request from the clients. The only drawback is reduced network range when this feature is enabled. Hence, we don't want to enable it by default.