Re: [PATCH 8/12] SUNRPC: Do not include crypto/algapi.h

Chuck Lever
2023-08-23T13:50:07Z

On Wed, Aug 23, 2023 at 06:32:30PM +0800, Herbert Xu wrote:
> The header file crypto/algapi.h is for internal use only. Use the
> header file crypto/utils.h instead.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Chuck Lever <chuck.lever@oracle.com>

> ---
>
> net/sunrpc/auth_gss/gss_krb5_crypto.c | 2 +-
> net/sunrpc/auth_gss/gss_krb5_unseal.c | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> index 9734e1d9f991..d2b02710ab07 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_crypto.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> @@ -34,9 +34,9 @@
> * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.
> */
>
> -#include <crypto/algapi.h>
> #include <crypto/hash.h>
> #include <crypto/skcipher.h>
> +#include <crypto/utils.h>
> #include <linux/err.h>
> #include <linux/types.h>
> #include <linux/mm.h>
> diff --git a/net/sunrpc/auth_gss/gss_krb5_unseal.c b/net/sunrpc/auth_gss/gss_krb5_unseal.c
> index 7d6d4ae4a3c9..b3ca30544e70 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_unseal.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_unseal.c
> @@ -57,11 +57,9 @@
> * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.
> */
>
> -#include <crypto/algapi.h>
> #include <linux/types.h>
> #include <linux/jiffies.h>
> #include <linux/sunrpc/gss_krb5.h>
> -#include <linux/crypto.h>
>
> #include "gss_krb5_internal.h"
>

--
Chuck Lever