linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] brcmfmac: Add an error log for brcmf_sdiod_ramrw()
@ 2025-04-07  4:20 Wentao Liang
  2025-04-20 18:15 ` Cannot maintain an ap with brcmfmac KeithG
  2025-07-19 20:57 ` brcmfmac: Can not completely turn off AP (BCM43340/2) Ferry Toth
  0 siblings, 2 replies; 4+ messages in thread
From: Wentao Liang @ 2025-04-07  4:20 UTC (permalink / raw)
  To: arend.vanspriel, kvalo
  Cc: sebastian.reichel, erick.archer, megi, linux-wireless, brcm80211,
	brcm80211-dev-list.pdl, linux-kernel, Wentao Liang

The function brcmf_sdio_buscore_activate() calls the function
brcmf_sdiod_ramrw(), but does not check its return value. Log
the error message to prevent silent failure if the function fails.

Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index b1727f35217b..dd683c2582fb 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -3898,8 +3898,9 @@ static void brcmf_sdio_buscore_activate(void *ctx, struct brcmf_chip *chip,
 
 	if (rstvec)
 		/* Write reset vector to address 0 */
-		brcmf_sdiod_ramrw(sdiodev, true, 0, (void *)&rstvec,
-				  sizeof(rstvec));
+		if (brcmf_sdiod_ramrw(sdiodev, true, 0, (void *)&rstvec,
+				      sizeof(rstvec)) < 0)
+			brcmf_err("Fail to reset vector\n");
 }
 
 static u32 brcmf_sdio_buscore_read32(void *ctx, u32 addr)
-- 
2.42.0.windows.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-19 20:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07  4:20 [PATCH] brcmfmac: Add an error log for brcmf_sdiod_ramrw() Wentao Liang
2025-04-20 18:15 ` Cannot maintain an ap with brcmfmac KeithG
2025-04-21  6:47   ` Arend Van Spriel
2025-07-19 20:57 ` brcmfmac: Can not completely turn off AP (BCM43340/2) Ferry Toth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).