Re: [PATCH] Fixing Style Problems

[Vaishali Thakkar <vaishali.thakkar@oracle.com>]

On Monday 27 March 2017 12:06 PM, vaibhavddit@gmail.com wrote:
> From: Vaibhav Kothari <vaibhavddit@gmail.com>
>
> - Corrected 80 characters column width

Hi,

There are very high chances that this patch will be ignored.
Mainly because you have not CC'ed proper mailing lists and
maintainers.

I'm just mentioning few things which this patch is lacking:

- Proper Subject and commit log
- Use of scripts/get_maintainer.pl for getting the list of mailing
   lists and maintainers
- The change itself doesn't look correct, most of the time we advise
   newbies to avoid sending patches for 80 characters line warning as
   original author might have some reason for not doing that change.

You can use this[1] and this[2] to improve your patch.

Thanks!

[1] https://kernelnewbies.org/FirstKernelPatch
[2] https://kernelnewbies.org/PatchPhilosophy

> Signed-off-by: Vaibhav Kothari <vaibhavddit@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
> index 5256f40..794104b 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.h
> +++ b/drivers/staging/wilc1000/coreconfigurator.h
> @@ -123,7 +123,7 @@ struct disconnect_info {
>  s32 wilc_parse_network_info(u8 *msg_buffer,
>  			    struct network_info **ret_network_info);
>  s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
> -			       struct connect_resp_info **ret_connect_resp_info);
> +			      struct connect_resp_info **ret_connect_resp_info);
>  void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer, u32 length);
>  void wilc_network_info_received(struct wilc *wilc, u8 *buffer, u32 length);
>  void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length);
>