From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wireless: Support auth-at-ms timer in sta-info
Date: Mon, 15 Apr 2019 19:03:12 +0200 [thread overview]
Message-ID: <dd9897b2800d68e241b63996e964cc94bde0db51.camel@sipsolutions.net> (raw)
In-Reply-To: <a8865096-f19e-608f-13c2-08036876d316@candelatech.com>
On Mon, 2019-04-15 at 09:32 -0700, Ben Greear wrote:
> On 4/15/19 4:15 AM, Johannes Berg wrote:
> > On Fri, 2019-04-12 at 14:37 -0700, greearb@candelatech.com wrote:
> > > From: Ben Greear <greearb@candelatech.com>
> > >
> > > Report time stamp of when sta became authenticated.
> >
> > You didn't actually implement this ;-)
> >
> > Did you mean associated?
> >
> > > + * @auth_at_ms: time in ms of the last assoc -> auth transition.
> >
> > There's commonly not really such a transition?
>
> Oh, I guess AUTHORIZED is only when doing .1x authentication? My test case
> was (luckly?) doing that, so I didn't notice the bug.
Oh, you meant *authorized*... Most of the code uses "auth" ==
"authenticated" :-)
johannes
prev parent reply other threads:[~2019-04-15 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 21:37 [PATCH 1/2] wireless: Support auth-at-ms timer in sta-info greearb
2019-04-12 21:37 ` [PATCH 2/2] mac80211: add auth-at-ms support greearb
2019-04-15 11:15 ` [PATCH 1/2] wireless: Support auth-at-ms timer in sta-info Johannes Berg
2019-04-15 16:32 ` Ben Greear
2019-04-15 17:03 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd9897b2800d68e241b63996e964cc94bde0db51.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox