From: akolli@codeaurora.org
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: "Kolli, Anilkumar" <akolli@qti.qualcomm.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4
Date: Tue, 18 Oct 2016 11:08:58 +0530 [thread overview]
Message-ID: <dde8d02e9ebf2eb9f37bb36c528548c2@codeaurora.org> (raw)
In-Reply-To: <87vawygo2w.fsf@kamboji.qca.qualcomm.com>
On 2016-10-12 10:29, Valo, Kalle wrote:
> <akolli@qti.qualcomm.com> writes:
>
>> From: Anilkumar Kolli <akolli@qti.qualcomm.com>
>>
>> Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS'
>> event, Firmware sends one HTT event for every four PPDUs.
>> HTT payload has success pkts/bytes, failed pkts/bytes, retry
>> pkts/bytes and rate info per ppdu.
>> Peer stats are enabled through 'WMI_SERVICE_PEER_STATS',
>> which are nowadays enabled by default.
>>
>> Parse peer stats and update the tx rate information per STA.
>>
>> tx rate, Peer stats are tested on QCA4019 with Firmware version
>> 10.4-3.2.1-00028.
>>
>> Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com>
>
> This and patch 2 add few new warnings:
>
> drivers/net/wireless/ath/ath10k/htt_rx.c: In function
> 'ath10k_htt_fetch_peer_stats':
> drivers/net/wireless/ath/ath10k/htt_rx.c:2279:3: warning: too many
> arguments for format [-Wformat-extra-args]
> drivers/net/wireless/ath/ath10k/htt_rx.c:2285:17: warning: incorrect
> type in assignment (different base types)
> drivers/net/wireless/ath/ath10k/htt_rx.c:2285:17: expected unsigned
> int [unsigned] [usertype] peer_id
> drivers/net/wireless/ath/ath10k/htt_rx.c:2285:17: got restricted
> __le16 [usertype] peer_id
> drivers/net/wireless/ath/ath10k/debugfs_sta.c:84: space required
> before the open parenthesis '('
I will fix and send V2.
Thanks,
Anil.
next prev parent reply other threads:[~2016-10-18 5:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 14:58 [PATCH 0/2] ath10k: add support for tx bitrate akolli
2016-10-07 14:58 ` [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4 akolli
2016-10-08 14:16 ` Yeoh Chun-Yeow
2016-10-12 4:59 ` Valo, Kalle
2016-10-12 13:36 ` Yeoh Chun-Yeow
2016-10-12 13:59 ` Valo, Kalle
2016-10-12 4:59 ` Valo, Kalle
2016-10-18 5:38 ` akolli [this message]
2016-10-07 14:58 ` [PATCH 2/2] ath10k: add support for per sta tx bitrate akolli
-- strict thread matches above, loose matches on Subject: below --
2016-10-18 9:29 [PATCHv2 0/2] ath10k: add support for " akolli
2016-10-18 9:29 ` [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4 akolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dde8d02e9ebf2eb9f37bb36c528548c2@codeaurora.org \
--to=akolli@codeaurora.org \
--cc=akolli@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).