linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* On EDCCA control in rtlwifi
@ 2023-10-22 13:31 Dmitry Antipov
  2023-10-23  2:29 ` Ping-Ke Shih
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Antipov @ 2023-10-22 13:31 UTC (permalink / raw)
  To: Ping-Ke Shih; +Cc: linux-wireless

I've noticed that 'rtl92ee_dm_dynamic_edcca()' and 'rtl8723be_dm_dynamic_edcca()'
are almost identical and both depends on 'pre_edcca_enable' of 'struct rtl_hal',
but only the first one can toggle it. Isn't it a bug somewhere?

Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: On EDCCA control in rtlwifi
  2023-10-22 13:31 On EDCCA control in rtlwifi Dmitry Antipov
@ 2023-10-23  2:29 ` Ping-Ke Shih
  0 siblings, 0 replies; 2+ messages in thread
From: Ping-Ke Shih @ 2023-10-23  2:29 UTC (permalink / raw)
  To: Dmitry Antipov; +Cc: linux-wireless@vger.kernel.org



> -----Original Message-----
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Sent: Sunday, October 22, 2023 9:31 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: linux-wireless@vger.kernel.org
> Subject: On EDCCA control in rtlwifi
> 
> I've noticed that 'rtl92ee_dm_dynamic_edcca()' and 'rtl8723be_dm_dynamic_edcca()'
> are almost identical and both depends on 'pre_edcca_enable' of 'struct rtl_hal',
> but only the first one can toggle it. Isn't it a bug somewhere?
> 

Every chip has its hardware characteristic, so it may do that intentionally, and
I can't find the reason why people did this. I suggest we don't touch EDCCA,
because even I have a hardware, I still can't confirm test result is positive
for the case the code intends to do. 

Ping-Ke


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-23  2:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-22 13:31 On EDCCA control in rtlwifi Dmitry Antipov
2023-10-23  2:29 ` Ping-Ke Shih

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).