From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH] wifi: brcmfmac: Fix potential use-after-free issue when stopping watchdog task
Date: Fri, 17 Apr 2026 21:26:46 +0200 [thread overview]
Message-ID: <de97fcd3-2ea5-4855-bfb1-99483a87deaa@broadcom.com> (raw)
In-Reply-To: <20260416093339.2066829-1-m.szyprowski@samsung.com>
On 16/04/2026 11:33, Marek Szyprowski wrote:
> Watchdog task might end between send_sig() and kthread_stop() calls, what
> results in the use-after-free issue. Fix this by increasing watchdog task
> reference count before calling send_sig() and dropping it by switching to
> kthread_stop_put().
>
> Fixes: 373c83a801f1 ("brcmfmac: stop watchdog before detach and free everything")
> Fixes: a9ffda88be74 ("brcm80211: fmac: abstract bus_stop interface function pointer")
Looks good to me. Maybe add stable?
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
[...]
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
prev parent reply other threads:[~2026-04-17 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260416093428eucas1p2fde898f84c1e15dd94d1ecb52707c72b@eucas1p2.samsung.com>
2026-04-16 9:33 ` [PATCH] wifi: brcmfmac: Fix potential use-after-free issue when stopping watchdog task Marek Szyprowski
2026-04-17 19:26 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de97fcd3-2ea5-4855-bfb1-99483a87deaa@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox