From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: rtlwifi: rtl8821ae: Fix media status report
Date: Thu, 19 Dec 2024 13:16:31 +0200 [thread overview]
Message-ID: <df141018-9981-44b3-bc40-29fd7898c809@gmail.com> (raw)
In-Reply-To: <c4fdab007c15450dbd37f4570095d157@realtek.com>
On 19/12/2024 05:47, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>>
>> RTL8821AE is stuck transmitting at the lowest rate allowed by the rate
>> mask. This is because the firmware doesn't know the device is connected
>> to a network.
>>
>> Fix the macros SET_H2CCMD_MSRRPT_PARM_OPMODE and
>> SET_H2CCMD_MSRRPT_PARM_MACID_IND to work on the first byte of __cmd,
>> not the second. Now the firmware is correctly notified when the device
>> is connected to a network and it activates the rate control.
>>
>> Before (MCS3):
>>
>> [ 5] 0.00-1.00 sec 12.5 MBytes 105 Mbits/sec 0 339 KBytes
>> [ 5] 1.00-2.00 sec 10.6 MBytes 89.1 Mbits/sec 0 339 KBytes
>> [ 5] 2.00-3.00 sec 10.6 MBytes 89.1 Mbits/sec 0 386 KBytes
>> [ 5] 3.00-4.00 sec 10.6 MBytes 89.1 Mbits/sec 0 386 KBytes
>> [ 5] 4.00-5.00 sec 10.2 MBytes 86.0 Mbits/sec 0 427 KBytes
>>
>> After (MCS9):
>>
>> [ 5] 0.00-1.00 sec 33.9 MBytes 284 Mbits/sec 0 771 KBytes
>> [ 5] 1.00-2.00 sec 31.6 MBytes 265 Mbits/sec 0 865 KBytes
>> [ 5] 2.00-3.00 sec 29.9 MBytes 251 Mbits/sec 0 963 KBytes
>> [ 5] 3.00-4.00 sec 28.2 MBytes 237 Mbits/sec 0 963 KBytes
>> [ 5] 4.00-5.00 sec 26.8 MBytes 224 Mbits/sec 0 963 KBytes
>>
>> Fixes: 39f40710d0b5 ("rtlwifi: rtl88821ae: Remove usage of private bit manipulation macros")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> Is this an urgent patch? or it's fine to go via rtw-next?
>
>
It's not urgent for me, rtw-next is fine.
next prev parent reply other threads:[~2024-12-19 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 22:53 [PATCH] wifi: rtlwifi: rtl8821ae: Fix media status report Bitterblue Smith
2024-12-19 3:47 ` Ping-Ke Shih
2024-12-19 11:16 ` Bitterblue Smith [this message]
2024-12-23 7:57 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df141018-9981-44b3-bc40-29fd7898c809@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox